Repository navigation
feat: auto link 2D signals to 1D signals - #4410
Merged
Merged
Conversation
hamed-musallam
commented
Oct 12, 2026
hamed-musallam
commented
Member
- Match each 2D signal axis to the closest 1D signal within the zone.
- Copy matched diaIDs and atom counts to the corresponding axis
- Generate assignment labels from the linked diaIDs
Closed
- Match each 2D signal axis to the closest 1D signal within the zone. - Copy matched diaIDs and atom counts to the corresponding axis - Generate assignment labels from the linked diaIDs
hamed-musallam
force-pushed
the
autolink-from-2d
branch
from
October 12, 2026 08:57
fc7cda9 to
d4eac61
Compare
Deploying nmrium with
|
| Latest commit: |
2ec946b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f056825e.nmrium.pages.dev |
| Branch Preview URL: | https://autolink-from-2d.nmrium.pages.dev |
hamed-musallam
marked this pull request as ready for review
October 12, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.