[chipkent]

Preview only. This is a draft in the fork showing the exact text of the PR planned for massive-com/client-python. It will be closed, not merged, once the upstream PR is opened.

Fixes #<issue: F5a>

BaseClient._get raises BadResponse(resp.data.decode("utf-8")) for any non-200 response, so the HTTP status is lost. Callers have to parse the body to tell a 403 (not entitled) from a 404.

• BadResponse takes a keyword-only status and stores it as an attribute; _get passes resp.status.
• str(exc) and exc.args are still the response body. BadResponse() and BadResponse("msg") still work, with status=None.
• massive/exceptions.py gets an __all__, so the package's from .exceptions import * does not re-export the new typing.Optional import as massive.Optional.

try:
    client.get_ticker_details("AAPL")
except BadResponse as e:
    if e.status == 403:
        ...  # the key is not entitled to this data

Tests in test_rest/test_bad_response.py drive 403 and 404 through pook and check that construction without a status is unchanged.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}