[chipkent]

Preview only. This is a draft in the fork showing the exact text of the PR planned for massive-com/client-python. It will be closed, not merged, once the upstream PR is opened.

Fixes #<issue: F1a-race>

Builds on #19: its test uses the mock server's inbox.

subscribe(), unsubscribe() and unsubscribe_all() are called while connect() runs, often from another thread, with no lock. The receive loop read scheduled_subs, awaited two sends, then copied scheduled_subs into subs and cleared schedule_resub. A change made during either await was recorded as sent but never sent, so the server streamed different topics from the ones requested.

• A lock now guards scheduled_subs and schedule_resub. The three methods hold it for their whole body, through a small decorator, so their code is not re-indented.
• The loop copies scheduled_subs and clears schedule_resub under the lock, sends from the copy, and records only the copy in subs. A change made during the sends goes out on the next turn.
• Code that changes scheduled_subs itself and sets schedule_resub = True still works.

# threads call subscribe()/unsubscribe() while connect() runs
# before: the server can end up streaming a different set from scheduled_subs
# now: it streams exactly scheduled_subs

Tests

• New test_threads.py makes a change from inside the subscribe send, the window another thread can hit, and checks that the server receives it. It fails every time without the fix.
• make test and make lint pass on 3.10 and 3.14.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}