Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
chipkent
force-pushed
the
fix/rest-options-param
branch
from
October 24, 2026 04:48
5aaea8a to
3989989
Compare
BaseClient._get_params turns a method's locals() into query parameters, skipping only `params` and `raw`. It did not skip `options`, so any REST method called with a RequestOptionBuilder also sent `options=<massive.rest.models.request.RequestOptionBuilder object at ...>` in the query string. Skip `options` too. Every endpoint builds its query through _get_params, so this fixes them all. Add regression tests for a GET and a paginated list call.
chipkent
force-pushed
the
fix/rest-options-param
branch
from
October 24, 2026 05:53
3989989 to
5b5b45f
Compare
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #<issue: F8>
BaseClient._get_paramsbuilds query parameters from the calling method'slocals(). It skipsparamsandrawbut notoptions, so a call such asalso sends
?options=<massive.rest.models.request.RequestOptionBuilder object at 0x...>."options"to the skip list. Every endpoint goes through_get_params, so this fixes them all.optionsare applied exactly as before.