Repository navigation
Conversation
veshant
added a commit
to veshant/cilium-proxy
that referenced
this pull request
Oct 2, 2026
Carry the source fix from cilium#2064 onto the exact proxy revision pinned by Cilium 1.20.2 for isolated image testing. Signed-off-by: Veshant Chettiar <veshantc@gmail.com>
veshant
marked this pull request as ready for review
October 5, 2026 05:48
veshant
force-pushed
the
fix-l7policy-null-upstream-addresses
branch
from
October 7, 2026 00:13
a895e9d to
065b690
Compare
jrajahalme
requested changes
Oct 7, 2026
jrajahalme
left a comment
jrajahalme
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution :-) Please squash commits into one, we do not do that automatically on merge and the commit-to-commit churn is not needed in the git history. I'll have a 2nd look when that is done.
Skip the same-tuple connection-close comparison when a local response has upstream information without established socket addresses. Cover missing and matching addresses in the L7 policy test. Signed-off-by: Veshant Chettiar <veshantc@gmail.com>
veshant
force-pushed
the
fix-l7policy-null-upstream-addresses
branch
from
October 9, 2026 21:21
065b690 to
29fa635
Compare
Author
|
@jrajahalme Thanks for the review. I’ve squashed the PR to one signed-off commit ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local HTTP reply can carry upstream info before an upstream socket has established local and remote addresses. When the reply includes
Connection: close,AccessFilter::encodeHeaders()dereferences those addresses while comparing the upstream and downstream socket tuples, which can crash Envoy.Guard that comparison until all four addresses are present. The existing downstream-drain behavior remains for matching socket tuples. Add regression cases for missing upstream addresses (both or either one), matching addresses, and nonmatching addresses.
Fixes #2063.
Validation:
clang-format18.1.8 passed with--dry-run --Werror, andgit diff --checkpassed. The C++ unit test could not be run locally because Docker BuildKit storage became read-only before compilation; CI should confirm compilation and behavior.