fix(genesis): require positive validator voting power - #346
Open
sanjeebdas1979 wants to merge 1 commit into
Open
fix(genesis): require positive validator voting power#346sanjeebdas1979 wants to merge 1 commit into
sanjeebdas1979 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require genesis validator configurations to include at least one validator with positive voting power.
The previous schema accepted both an empty validator set and a set where every validator had zero voting power. Consensus-side decoding later rejects the resulting empty effective validator set, so this validation moves the failure earlier to genesis configuration time.
Changes
Testing
Fixes #344