Skip to content

fix(genesis): require positive validator voting power - #346

Open
sanjeebdas1979 wants to merge 1 commit into
circlefin:mainfrom
sanjeebdas1979:fix/genesis-require-positive-voting-power
Open

fix(genesis): require positive validator voting power#346
sanjeebdas1979 wants to merge 1 commit into
circlefin:mainfrom
sanjeebdas1979:fix/genesis-require-positive-voting-power

Conversation

@sanjeebdas1979

@sanjeebdas1979 sanjeebdas1979 commented Sep 4, 2026

Copy link
Copy Markdown

Summary

Require genesis validator configurations to include at least one validator with positive voting power.

The previous schema accepted both an empty validator set and a set where every validator had zero voting power. Consensus-side decoding later rejects the resulting empty effective validator set, so this validation moves the failure earlier to genesis configuration time.

Changes

  • Add set-level validation requiring at least one validator with positive voting power.
  • Preserve support for zero-power validators when another validator has positive voting power.
  • Add regression tests covering:
    • empty validator set
    • all-zero voting power
    • positive-only validator set
    • mixed zero/positive validator set

Testing

ValidatorManager genesis validator-set validation
  ✔ rejects an empty validator set
  ✔ rejects a validator set with no positive voting power
  ✔ accepts a validator set with positive voting power
  ✔ accepts zero-power validators when another validator has positive power

4 passing

Fixes #344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(genesis): ValidatorManager accepts validator sets with no positive voting power

1 participant