Add sql paths 14.0-1--14.1-1 & 14.1-1--15.0-1 to main after #8558#8559
Closed
onurctirtir wants to merge 2 commits intomainfrom
Closed
Add sql paths 14.0-1--14.1-1 & 14.1-1--15.0-1 to main after #8558#8559onurctirtir wants to merge 2 commits intomainfrom
onurctirtir wants to merge 2 commits intomainfrom
Conversation
onurctirtir
force-pushed
the
main-sync-rel14-mx
branch
from
29cdd2a to
50e0223
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8559 +/- ##
=======================================
Coverage 88.78% 88.79%
=======================================
Files 287 287
Lines 64046 64046
Branches 8051 8051
=======================================
+ Hits 56865 56871 +6
+ Misses 4850 4849 -1
+ Partials 2331 2326 -5 🚀 New features to boost your workflow:
|
onurctirtir
changed the title
onurctirtir
force-pushed
the
main-sync-rel14-mx
branch
from
50e0223 to
e73a56a
Compare
This needs to be taken to main branch too. 1. Move more tests that are creating Citus extension into multi_1_create_citus_schedule. 2. Remove unnecessary worker tests from schema_based_sharding.sql as we're anyway testing them a lot in other test files. 3. Also add a placeholder section at the end of multi_1_create_citus_schedule for the tests that need to be moved back to their original schedules with the next major version of Citus. (cherry picked from commit cb512a3)
onurctirtir
force-pushed
the
main-sync-rel14-mx
branch
from
e73a56a to
cccf6d3
Compare
onurctirtir
requested review from
codeforall and
eaydingol
and removed request for
eaydingol
onurctirtir
changed the title
onurctirtir
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should reflect the SQL state changed by Backport #8541 to release-14 via new sql path 14.0-1--14.1-1 #8558 at 14.1-1 in main branch too.
And while doing that, we can delete the changes that have been made on main to introduce them at 15.0-1, because we don't need to re-introduce SQL objects introduced at 14.1-1 again at 15.0-1.
In short, given Backport #8541 to release-14 via new sql path 14.0-1--14.1-1 #8558, move the SQL changes made at 14.0-1--15.0-1 in Support some of the DDLs for schema-based-sharding from any node #8541 to 14.0-1--14.1-1.
Also, move the SQL changes made at 14.0-1--15.0-1 in Add citus_cluster_changes_{block,unblock,block_status} UDFs for cluster-wide backup coordination #8543 to 14.1-1--15.0-1.
As can be seen in "Files Changed" tab, "src/backend/distributed/sql/downgrades/citus--15.0-1--14.0-1.sql" has been renamed, but check-style is failing with the following error.
So that's actually wrong, please nvm it: