add postgres19 compatibility#172
Open
sibowu-aws wants to merge 1 commit intocitusdata:masterfrom
Open
Conversation
|
@sibowu-aws please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #171
Fix postgresql-hll for PostgreSQL 19 compatibility
Change InitializeHllAggregateOids() to InitializeHllAggregateOids(void).
PG19 compiles with -Werror=old-style-definition, which rejects empty
parameter lists as K&R-style declarations.
Add PG19 branch for FuncnameGetCandidates() which added a new
int *fgc_flags output parameter. PG19 unconditionally dereferences
this pointer (*fgc_flags = 0), so passing NULL causes a server crash.
Pass &fgc_flags with a local int variable instead.
Use AllocSetContextCreateInternal() directly for PG19. The
AllocSetContextCreate macro wraps the call in StaticAssertExpr(),
which in PG19 uses C23 static_assert inside a struct. GCC 12 does
not support this construct, causing a compile error.
Add expected/card_op_1.out and expected/hash_1.out alternative
output files. PG19 changed error messages to split the old single
HINT line into separate DETAIL and HINT lines for function/operator
lookup failures.
All code changes are guarded with #if PG_VERSION_NUM >= 190000 and
do not affect PG18 or earlier.