Skip to content

Use the canonical audit-clerk-skill in clerk/skills - #540

Open
SarahSoutoul wants to merge 5 commits into
mainfrom
ss/DOCS-12114
Open

SarahSoutoul wants to merge 5 commits into
mainfrom
ss/DOCS-12114

Conversation

@SarahSoutoul

@SarahSoutoul SarahSoutoul commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What does this solve? What changed?

This is the clerk/cli half of DOCS-12114. The audit instructions had diverged between the CLI and skills repositories, and the old CLI copy still pointed at the categorized skills/core/clerk-cli/ path.

  • Replace the detailed CLI-local audit skill with a short, invocable pointer to the canonical instructions in clerk/skills. Keep its .agents/skills/ discovery symlink.
  • Point AGENTS.md to the same canonical audit skill, which uses the current flat skills/clerk-cli/ path.
  • The pointer tells an agent to use this CLI checkout as the source and a clerk/skills checkout as the target. It stops if the canonical instructions are unavailable rather than using a stale local copy.

This does not change CLI runtime behavior. Running the audit from this repo now requires access to clerk/skills.

Deadline

No fixed deadline. Coordinate with the paired Expo skill PR.

Other resources

@changeset-bot

changeset-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4e36dae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 6da49a1a-8479-4f3a-9ca0-6924cea32c60
Commits

Reviewing files that changed from the base of the PR and between aa8891b and 4e36dae.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 643ced1a-aae8-456e-948e-10380c01925c
📥 Commits

Reviewing files that changed from the base of the PR and between 2133e7e and aa8891b.

📒 Files selected for processing: 2
  • .claude/skills/audit-clerk-skill/SKILL.md
  • AGENTS.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

Walkthrough

The audit skill now directs maintainers to read the canonical instructions in clerk/skills, locate or clone that checkout, and run its audit with this CLI checkout passed as --source. It also specifies when to stop and how long to retain the skills checkout when using --apply. AGENTS.md points maintainers to the canonical skill.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: wyattjoh

Merge Risk: Minimal · previous review aa889

Audit guidance is centralized in clerk/skills, with a local pointer retained. No runtime change or actionable merge risk is evident from the supplied context.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: using the canonical audit skill in clerk/skills.
Description check Passed The description accurately explains the changes, affected files, canonical skill workflow, dependency on clerk/skills, and lack of runtime behavior changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@SarahSoutoul SarahSoutoul self-assigned this Oct 16, 2026
@SarahSoutoul
SarahSoutoul marked this pull request as ready for review October 16, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant