test(mosaic): cover reconnect scopes, email SSO and web3 verify gating by alexcarpenter · Pull Request #10476 · clerk/javascript

alexcarpenter · 2026-10-27T22:49:39Z

Description

Tightens user profile tests that let a broken line in the model pass. Each change fails when the matching model line is broken by hand (a hand-run mutation pass).

Connected accounts: recreating a disconnected account now checks that the scopes the app requests are sent. Dropping them used to pass.
Email: verifying an address through enterprise SSO now checks that the user is sent back to the page they were on. A new test checks that an immutable email attribute still lists addresses but offers no Remove.
Web3 wallets: the projection test now checks that Verify is not offered for a wallet that is already verified, or whose provider the instance turned off.

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…removal, and web3 verify gating

changeset-bot · 2026-10-27T22:49:43Z

🦋 Changeset detected

Latest commit: 20cde20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-10-27T22:49:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Oct 28, 2026 12:18am UTC
swingset	Ready	Preview	Oct 28, 2026 12:18am UTC

coderabbitai · 2026-10-27T22:49:58Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: carp/mosaic-user-profile-step3-tests
File: .coderabbit.yaml
Commit: 20cde20
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 6c7cb6a1-4a74-4333-8618-61544399a043

Commits

Reviewing files that changed from the base of the PR and between 420a3e8 and 20cde20.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: clerk/javascript
Branch: carp/mosaic-user-profile-step3-tests
File: .coderabbit.yaml
Commit: 420a3e8
Layers: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 56eed442-1afe-4b20-9dfb-b6a16fccba71

Commits

Reviewing files that changed from the base of the PR and between debfc72 and 420a3e8.

Files selected for processing: 4

.changeset/mosaic-user-profile-step3-tests.md
packages/mosaic/src/features/user-profile/user-profile-connected-accounts-section/__tests__/user-profile-connected-accounts.reconnect.feature.test.tsx
packages/mosaic/src/features/user-profile/user-profile-email-section/__tests__/user-profile-email-section.feature.test.tsx
packages/mosaic/src/features/user-profile/user-profile-web3-wallets-section/__tests__/user-profile-web3-wallets-section.model.test.ts

Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

clerk/clerk_go (manual)
clerk/dashboard (manual)
clerk/accounts (manual)
clerk/backoffice (manual)
clerk/clerk (manual)
clerk/clerk-docs (manual)
clerk/cloudflare-workers (manual)
clerk/clerk-android (auto-detected)
clerk/cli (auto-detected)
clerk/clerk-ios (auto-detected)

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The pull request adds tests for requested OAuth scopes during connected-account reconnection, SSO verification request parameters, and immutable email settings. It expands wallet verification tests to cover three conditions. It also adds an empty changeset file.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: austincalvelage

Merge Risk: Minimal · previous review 420a3

The PR adds targeted regression coverage without an identified current-head production risk.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title accurately names the main change: added test coverage in the user-profile area for reconnect scopes, email SSO return, and web3 Verify gating. It uses the conventional test(scope) prefix and…
Description check		The description states the purpose: tightening user-profile tests so that hand-broken model lines fail them. It lists the three affected areas (connected accounts, email, web3 wallets) and the new ass…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title accurately names the main change: added test coverage in the user-profile area for reconnect scopes, email SSO return, and web3 Verify gating. It uses the conventional test(scope) prefix and is specific, though it lists three areas.

Full details: Description check

Explanation

The description states the purpose: tightening user-profile tests so that hand-broken model lines fail them. It lists the three affected areas (connected accounts, email, web3 wallets) and the new assertions, which matches the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (1 skipped: 1 unsupported.)

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-27T22:52:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10476

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10476

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10476

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10476

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10476

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10476

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10476

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10476

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10476

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10476

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10476

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10476

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10476

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10476

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10476

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10476

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10476

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10476

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10476

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10476

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10476

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10476

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10476

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10476

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10476

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10476

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10476

commit: 20cde20

test(mosaic): cover reconnect scopes, email SSO return and immutable …

420a3e8

…removal, and web3 verify gating

github-actions Bot added the mosaic label Oct 27, 2026

vercel Bot deployed to Preview – clerk-js-sandbox October 27, 2026 22:50

View deployment

alexcarpenter requested a review from austincalvelage October 27, 2026 22:50

vercel Bot deployed to Preview – swingset October 27, 2026 22:52

View deployment

Merge branch 'main' into carp/mosaic-user-profile-step3-tests

20cde20

vercel Bot deployed to Preview – clerk-js-sandbox October 28, 2026 00:15

View deployment

vercel Bot deployed to Preview – swingset October 28, 2026 00:18

View deployment

Navigation Menu

Repository navigation

test(mosaic): cover reconnect scopes, email SSO and web3 verify gating - #10476

test(mosaic): cover reconnect scopes, email SSO and web3 verify gating#10476
alexcarpenter wants to merge 2 commits into
mainfrom
carp/mosaic-user-profile-step3-tests

alexcarpenter commented Oct 27, 2026

Uh oh!

changeset-bot Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

Review skipped

Uh oh!

pkg-pr-new Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

alexcarpenter commented Oct 27, 2026

Description

Checklist

Type of change

Uh oh!

changeset-bot Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

pkg-pr-new Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot Bot commented Oct 27, 2026 •

edited

Loading

vercel Bot commented Oct 27, 2026 •

edited

Loading

coderabbitai Bot commented Oct 27, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 27, 2026 •

edited

Loading