Skip to content

Commit ea834ac

Browse files
authored
CI - move pnpm build into cargo ci test (#4855)
# Description of Changes To make `cargo ci test` more properly include the full test logic. # API and ABI breaking changes <!-- If this is an API or ABI breaking change, please apply the corresponding GitHub label. --> # Expected complexity level and risk 1 # Testing honestly none --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
1 parent 1c10afe commit ea834ac

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -255,10 +255,6 @@ jobs:
255255
256256
wasm-bindgen --version
257257
258-
- name: Build typescript module sdk
259-
working-directory: crates/bindings-typescript
260-
run: pnpm build
261-
262258
# Source emsdk environment to make emcc (Emscripten compiler) available in PATH.
263259
- name: Run tests
264260
run: |

tools/ci/src/main.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,8 @@ fn main() -> Result<()> {
306306

307307
match cli.cmd {
308308
Some(CiCmd::Test) => {
309+
cmd!("pnpm", "build").dir("crates/bindings-typescript").run()?;
310+
309311
// TODO: This doesn't work on at least user Linux machines, because something here apparently uses `sudo`?
310312

311313
// Exclude smoketests from `cargo test --all` since they require pre-built binaries.

0 commit comments

Comments
 (0)