Update #2151 to post .NET 10#5530
Draft
lisandroct wants to merge 133 commits into
Draft
Conversation
1) Created exception to `check_global_json_policy` to allow for .NET 8 templates to be generated. 2) Removed .NET 10 DLLs from SDK to prevent Unity issue. 3) Updated NativeAOT smoketest test include `packageSourceMapping` in `NuGet.Config`.
…SDK` for Windows builds
- Add --dotnet-version flag to build/publish/init commands for explicit .NET version control - Fix smoketests to use local SpacetimeDB.Runtime/BSATN.Runtime packages (not public NuGet) - Fix CLI binary path detection for debug vs release builds - Add NativeAOT-LLVM output paths (native/ subdirectory) to csharp.rs - Force .NET 8 for C# templates in template tests to match template TFM
…rsion `25` from `29`
…imental` can install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Re-implements #2151 on top of latest master and .NET 10 support.
Reuse C# runtime buffers when consuming
BytesSourcevalues from module FFI exports instead of allocating fresh byte arrays for each call.It's reasonable and the benchmarks results are enticing. These changes obviously make sense as long as Wasm module execution stays single-threaded. If future module execution becomes concurrent (or we re-enter these exports recursively), these buffers become unsafe.
I ran the benchmarks two times (with high variability in some cases):
The results are good (negative numbers mean faster execution) in all benchmarks except
filter string index,filter u64 indexand maybeinsert u32/u64/u64 btree. They don't match the original branch results. I assume this comes down to a difference in hardware and .NET SDK version (I ran the benchmarks on .NET 10 with NativeAOT-LLVM).These changes are probably worth applying.
API and ABI breaking changes
No breaking changes.
Expected complexity level and risk
Testing