Fix pre-commit rustfmt skip paths for core crate#5533
Open
Shiven0504 wants to merge 4 commits into
Open
Conversation
Update git-hooks/hooks/pre-commit to match the current crate layout. The old exclusions used the removed path crates/spacetimedb-core/..., so messages.rs and protobuf output were being formatted instead of skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
pre-commithook to reflect the repository's current crate layout forrustfmtskip checks.Previously, the hook excluded
messages.rsandcrates/spacetimedb-core/src/protobuf/*.rs. Since the repository no longer contains theprotobufdirectory underspacetimedb-core, the skip pattern had become outdated, causingmessages.rsto be formatted instead of being excluded.This change updates the skip paths so the hook correctly matches the current repository structure. Fixes #5532
API and ABI Breaking Changes
Risk / Complexity
Testing
Verified the updated hook diff.
Confirmed the skip paths match the current repository layout.
Validated the hook syntax using: