Skip to content

Remove colors from disk logs#5534

Open
jsdt wants to merge 1 commit into
masterfrom
jsdt/logging-color-settings
Open

Remove colors from disk logs#5534
jsdt wants to merge 1 commit into
masterfrom
jsdt/logging-color-settings

Conversation

@jsdt

@jsdt jsdt commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

This changes our logging setup with the goal of getting rid of ansi color codes outside of the terminal.

We now have two separate layers for writing to files vs stdout, and we only add colors to stdout if it is a terminal. In case the latter doesn't work for some reason, ansi colors can also be turned off with the NO_COLOR env variable.

Expected complexity level and risk

1.5 This should be straightforward, and the only risk would affect logging formatting.

@jsdt jsdt marked this pull request as ready for review July 13, 2026 18:07
@jsdt jsdt requested a review from bfops July 13, 2026 18:07
Comment thread crates/core/src/startup.rs

@bfops bfops left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me, although I admittedly don't have much context on this code

@Shubham8287 Shubham8287 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants