Remove colors from disk logs#5534
Open
jsdt wants to merge 1 commit into
Open
Conversation
…tput, and add an env var to disable color
bfops
reviewed
Jul 13, 2026
bfops
approved these changes
Jul 13, 2026
bfops
left a comment
Collaborator
There was a problem hiding this comment.
seems reasonable to me, although I admittedly don't have much context on this code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes our logging setup with the goal of getting rid of ansi color codes outside of the terminal.
We now have two separate layers for writing to files vs stdout, and we only add colors to stdout if it is a terminal. In case the latter doesn't work for some reason, ansi colors can also be turned off with the NO_COLOR env variable.
Expected complexity level and risk
1.5 This should be straightforward, and the only risk would affect logging formatting.