Account for PacketStart offsets in packet guards - #47
Open
arthurfabre wants to merge 1 commit into
Open
Conversation
The verifier rejects any programs that accesses packets with offsets greater than 0xFFFF. For absolute loads we can detect this statically, for indirect loads we insert a runtime check. But our checks didn't account for any pre-existing offset to the packet pointer the caller passes in! (eg because the caller has parsed / skipped the ethernet header). This must be accounted for in the maximum offset check. Add an option to both EBPFOpts and COpts to allow users to specify the maximum offset the packet pointer may have, so it can be included in the static analysis for absolute loads, and the runtime checks for indirect loads. Thank you to @Dhiver for figuring this out in #45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verifier rejects any programs that accesses packets with offsets greater than 0xFFFF.
For absolute loads we can detect this statically, for indirect loads we insert a runtime check.
But our checks didn't account for any pre-existing offset to the packet pointer the caller passes in! (eg because the caller has parsed / skipped the ethernet header).
This must be accounted for in the maximum offset check.
Add an option to both EBPFOpts and COpts to allow users to specify the maximum offset the packet pointer may have, so it can be included in the static analysis for absolute loads, and the runtime checks for indirect loads.
Thank you to @Dhiver for figuring this out in #45.