Skip to content

[DO] Address review feedback on metrics filter changelog#31441

Merged
iglesiasbrandon merged 2 commits into
productionfrom
changelog/do-metrics-filter-followup
Jun 15, 2026
Merged

[DO] Address review feedback on metrics filter changelog#31441
iglesiasbrandon merged 2 commits into
productionfrom
changelog/do-metrics-filter-followup

Conversation

@iglesiasbrandon

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #31316 (merged) addressing post-merge review comments from @vy-ton on the Durable Objects metrics filter changelog entry:

  • Move the dashboard screenshot to immediately after the DashButton so readers see the UI before reading how to use it.
  • Clarify that the autocomplete only lists objects with invocations during the selected time range — a missing object means no recent invocations, not that the object has been deleted (confirmed by @apeacock1991 in the original PR thread).

Documentation checklist

- Move the dashboard screenshot to immediately after the DashButton so
  readers see the UI before the description of how to use it.
- Note that the autocomplete only lists objects with invocations during
  the selected time range, so a missing object means no recent
  invocations rather than deletion.

Addresses post-merge review comments on #31316.
@github-actions

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/src/content/changelog/ @cloudflare/pm-changelogs, @cloudflare/product-owners

@ask-bonk ask-bonk Bot added changelog Adds or updates changelog entries/pages. product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ product:workers Related to Workers product labels Jun 13, 2026

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style suggestion; otherwise LGTM. Applied labels: , , .

Start typing an ID or name into the filter and select a match from the autocomplete dropdown. Every chart on the page updates to reflect only the selected object. This makes it easier to identify and investigate a single Durable Object when debugging a high-traffic object, an error spike, or unexpected storage usage. Clear the filter to return to namespace-level metrics.
![The Durable Objects Metrics tab filtered to a single object by ID, showing per-object requests and errors by invocation status.](~/assets/images/changelog/durable-objects/durable-objects-metrics-dashboard.png)

Start typing an ID or name into the filter and select a match from the autocomplete dropdown. The autocomplete only shows objects with invocations during the selected time range, so an object that does not appear has not been invoked in that window — it has not necessarily been deleted. Every chart on the page updates to reflect only the selected object. This makes it easier to identify and investigate a single Durable Object when debugging a high-traffic object, an error spike, or unexpected storage usage. Clear the filter to return to namespace-level metrics.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split the long sentence to match the style guide:

Suggested change
Start typing an ID or name into the filter and select a match from the autocomplete dropdown. The autocomplete only shows objects with invocations during the selected time range, so an object that does not appear has not been invoked in that window — it has not necessarily been deleted. Every chart on the page updates to reflect only the selected object. This makes it easier to identify and investigate a single Durable Object when debugging a high-traffic object, an error spike, or unexpected storage usage. Clear the filter to return to namespace-level metrics.
Start typing an ID or name into the filter and select a match from the autocomplete dropdown. The autocomplete only shows objects with invocations during the selected time range. An object that does not appear has not been invoked in that window — it has not necessarily been deleted. Every chart on the page updates to reflect only the selected object. This makes it easier to identify and investigate a single Durable Object when debugging a high-traffic object, an error spike, or unexpected storage usage. Clear the filter to return to namespace-level metrics.

@ask-bonk

ask-bonk Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review complete for PR #31441.

Summary of changes:

  • Moves the Durable Objects metrics dashboard screenshot from the bottom of the changelog entry to immediately after the DashButton component.
  • Adds a clarifying sentence that the autocomplete only lists objects with invocations during the selected time range.
  • Removes the trailing blank line and image at the bottom.

Actions taken:

  • Applied labels: changelog, product:durable-objects, product:workers.
  • Posted one inline suggestion on line 18 to split a 29-word sentence into two shorter sentences, conforming to the 8–12 word style guide target.

No blocking issues found. Links, image path, frontmatter, and component imports are all correct.

github run

@iglesiasbrandon iglesiasbrandon marked this pull request as ready for review June 13, 2026 13:48
@iglesiasbrandon iglesiasbrandon requested review from a team as code owners June 13, 2026 13:48
@cloudflare cloudflare deleted a comment from cloudflare-docs-bot Bot Jun 13, 2026
@mvvmm

mvvmm commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

/full-review

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No style-guide issues found in full PR diff.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

Start typing an ID or name into the filter and select a match from the autocomplete dropdown. Every chart on the page updates to reflect only the selected object. This makes it easier to identify and investigate a single Durable Object when debugging a high-traffic object, an error spike, or unexpected storage usage. Clear the filter to return to namespace-level metrics.
![The Durable Objects Metrics tab filtered to a single object by ID, showing per-object requests and errors by invocation status.](~/assets/images/changelog/durable-objects/durable-objects-metrics-dashboard.png)

Start typing an ID or name into the filter and select a match from the autocomplete dropdown. The autocomplete only shows objects with invocations during the selected time range, so an object that does not appear has not been invoked in that window. This does not necessarily mean the object has been deleted. Every chart on the page updates to reflect only the selected object. This makes it easier to identify and investigate a single Durable Object when debugging a high-traffic object, an error spike, or unexpected storage usage. Clear the filter to return to namespace-level metrics.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the UI provide this affordance or do you need to read the docs page here in order to figure this out?

@apeacock1991

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI doesn't yet, we have a bunch of fast-follow UI updates (inc. addressing this one) this week!

@alainsignorelli59-cmd

alainsignorelli59-cmd commented Jun 14, 2026 via email

Copy link
Copy Markdown

@iglesiasbrandon iglesiasbrandon merged commit dda6dec into production Jun 15, 2026
23 checks passed
@iglesiasbrandon iglesiasbrandon deleted the changelog/do-metrics-filter-followup branch June 15, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Adds or updates changelog entries/pages. product:changelog product:durable-objects Durable Objects: https://developers.cloudflare.com/workers/learning/using-durable-objects/ product:workers Related to Workers product size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants