Skip to content

[Workers] Update GitHub Actions example to use wrangler-action@v4 and note build step - #33510

Open
Guardiansoftiktok wants to merge 1 commit into
cloudflare:productionfrom
Guardiansoftiktok:docs/wrangler-action-v4-github-actions-example
Open

Guardiansoftiktok wants to merge 1 commit into
cloudflare:productionfrom
Guardiansoftiktok:docs/wrangler-action-v4-github-actions-example

Conversation

@Guardiansoftiktok

Copy link
Copy Markdown

Summary

Updates the GitHub Actions example on the Workers CI/CD page so that:

  1. cloudflare/wrangler-action@v3@v4 — matches the current default of the action (Wrangler v4). Users copying the example today land on the older major version.
  2. Adds a commented-out build step# - name: Build / # run: npm ci && npm run build. This mirrors the pattern already used on the Pages direct-upload CI page, so users deploying Workers built with a bundler or framework (Tanstack Start, Next-on-Workers, Astro, etc.) see where to hook the build in. Without it, users have been hitting runtime errors like entry-point file at "..." was not found because the example doesn't mention a build.
  3. Renames the step Build & Deploy WorkerDeploy Worker — the old name implied a build was happening inside the wrangler-action step, which was misleading.

Reported in cloudflare/wrangler-action#408.

Test plan

  • Change is contained inside a YAML code block — no MDX syntax touched, renders unchanged
  • Frontmatter unchanged
  • Matches existing house style already used on the Pages CI page

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review

✅ No issues found in commit 2df0a24.

Code Review

This code review is in beta and may not always be helpful — use your judgment.

No code review issues found.

Conventions

No convention issues found.

Style Guide Review

No style-guide issues found.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.
/ignore-review-limit Permanently lifts the 2-review automatic limit for this PR. Future pushes will trigger reviews as normal.
/disable-auto-review Stops automatic reviews from triggering on future pushes to this PR. Codeowners can still run /review or /full-review manually.
/rebase Rebases the PR branch against production. On conflict, attempts to resolve automatically using AI. Stops with an explanation if confidence is not high enough.

@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review coverage

🟡 1 ownership area needs approval.

Suggested reviewers: @dinasaur404 @irvinebroque

Needs approval Eligible approvers Suggested
workers @aninibread, @ericclemmons, @GregBrimble, @irvinebroque, @MattieTK, @vy-ton, @yomna-shousha, @cloudflare/product-owners dinasaur404, irvinebroque
CODEOWNERS mappings for displayed areas (1)
Pattern Owners
/src/content/docs/workers/ci-cd/ @aninibread, @ericclemmons, @GregBrimble, @irvinebroque, @MattieTK, @vy-ton, @yomna-shousha, @cloudflare/product-owners

@nyreegloriani2-prog

nyreegloriani2-prog commented Sep 17, 2026 via email

Copy link
Copy Markdown

@nyreegloriani2-prog

nyreegloriani2-prog commented Sep 17, 2026 via email

Copy link
Copy Markdown

… note build step

- Bump cloudflare/wrangler-action@v3 to @v4 (matches current default).
- Add commented-out 'npm ci && npm run build' block matching the style
  used on the Pages direct-upload CI page, so users deploying Workers
  built with a bundler or framework know where the build step goes.
- Rename 'Build & Deploy Worker' step to 'Deploy Worker', since the
  build step is now shown separately.

Reported in cloudflare/wrangler-action#408.
@Guardiansoftiktok
Guardiansoftiktok force-pushed the docs/wrangler-action-v4-github-actions-example branch from 8dc925f to 2df0a24 Compare September 19, 2026 13:35
@Guardiansoftiktok

Copy link
Copy Markdown
Author

Rebased onto production after #33536 merged. That PR (thanks!) already handled the @v3 → @v4 bump on the same example, so I've dropped that hunk. What remains here is:

  1. A commented-out build-step block matching the pattern used on the Pages direct-upload CI page — so users deploying Workers built with a bundler or framework (Tanstack Start, Next-on-Workers, Astro, etc.) can see where to hook a build in. This is the original user complaint from cloudflare/wrangler-action#408.
  2. Named the checkout step (- name: Checkout) and renamed the deploy step (Deploy Worker instead of Build & Deploy Worker) so the step name matches what the step actually does now that build is a separate marker.

Happy to trim further if the smaller scope after #33536 makes any of this not worth carrying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants