Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optional retry window for HTTP origin connections. This can be helpful during application restarts or deployments, when an origin briefly stops listening on its TCP port or Unix socket. This way the public visitors will not see an outage, and the newest application deployment, once started up, will pick up the connections queued.
Notable Changes
originRequest.connectRetryTimeout, globally or per ingress rule. Retries are disabled by default; an explicit 0s disables an inherited setting. Negative values are rejected.--proxy-connect-retry-timeoutandTUNNEL_PROXY_CONNECT_RETRY_TIMEOUTfor origins configured through--urlor--unix-socket.DialContextthrough the retry helper,return dialOriginWithRetry(ctx, network, address, httpTransport.connectRetryTimeout, dialer.DialContext)The helper retries refused connections and missing Unix sockets using the existing exponential backoff with jitter. One deadline bounds all attempts and waits; connectTimeout still limits individual attempts.
I'm assuming this change is small enough not to deserve an issue discussion, as per the contribution guide.