Conversation
… serialization With the `enhanced_error_serialization` compat flag, on since compat date 2026-04-21, a PythonError tunneled over RPC keeps `name == "PythonError"` and its message is the bare traceback, rather than a plain Error whose message starts with "PythonError: ". This updates `_from_js_error` to account for it.
… step name The Workflows engine allows the same step name to be used more than once, but the Python wrapper tracked in-flight tasks and memoised results by name. Two same-named steps running concurrently raised KeyError when the second one finished, and could observe each other's results.
Instead of `to_js`.
…ith the SDK wrangler registers `.js`/`.mjs` files under `python_modules/workers/` as ES modules, so JavaScript can ship inside the `workers` package and be loaded at runtime.
…n-retryable The Workflows engine decides whether to retry a failed step from the JS error's name. A Python exception reaches it as a Pyodide PythonError whose message is the traceback, so `workers.workflows.NonRetryableError` was silently retried like any other error. This adds a new workflows.js shim that fixes the translation of NonRetryableError to JavaScript so this works correctly.
Contributor
|
Could you please split |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit series fixes a bunch of minor bugs in workflows. I can split them into separate PRs if the reviewers prefer, otherwise we should merge not squash.