Merge pull request #76 from stat-kwon/master

Resolve duplication of error logs

Author: stat-kwon

src/spaceone/core/fastapi/api.py

@@ -45,10 +45,8 @@ async def wrapper(*args, **kwargs):
 
 
 def _print_error_log(error):
-    _LOGGER.error(f'(Error) => {error.message} {error}',
-                  extra={'error_code': error.error_code,
-                         'error_message': error.message,
-                         'traceback': traceback.format_exc()})
+    if not error.meta.get('skip_error_log'):
+        _LOGGER.error(f'(Error) => {error.message} {error}', exc_info=True)
 
 
 def _raise_exception(error):
@@ -61,7 +59,6 @@ def _check_http_status_code(grpc_status_code: str) -> int:
 
 
 class BaseAPI(object):
-
     locator = Locator()
     service = None
 

src/spaceone/core/pygrpc/api.py

@@ -64,10 +64,9 @@ def get_minimal(params):
     def _error_method(error, context):
         if not isinstance(error, ERROR_BASE):
             error = ERROR_UNKNOWN(message=error)
-            _LOGGER.error(f'(Error) => {error.message} {error}',
-                          extra={'error_code': error.error_code,
-                                 'error_message': error.message,
-                                 'traceback': traceback.format_exc()})
+
+        if not error.meta.get('skip_error_log'):
+            _LOGGER.error(f'(Error) => {error.message} {error}', exc_info=True)
 
         details = f'{error.error_code}: {error.message}'
         context.abort(grpc.StatusCode[error.status_code], details)

src/spaceone/core/service/service.py

@@ -158,6 +158,8 @@ def _error_handler(self, error):
     if not isinstance(error, ERROR_BASE):
         error = ERROR_UNKNOWN(message=error)
 
+    error.meta['skip_error_log'] = True
+
     # Failure Event
     if _check_handler_method(self, 'event'):
         for handler in self.handler['event']['handlers']: