Prevent DropletUpload from downgrading a staged droplet to failed#5244
Open
svkrieger wants to merge 1 commit into
Open
Prevent DropletUpload from downgrading a staged droplet to failed#5244svkrieger wants to merge 1 commit into
svkrieger wants to merge 1 commit into
Conversation
If a worker is killed mid-job and restarts, it re-locks and re-runs its own job. When another worker already completed the job in the meantime, the droplet is already STAGED. The rescue block would unconditionally overwrite STAGED with FAILED in that case. Skip the state transition and log when the droplet is already staged.
svkrieger
force-pushed
the
fix-droplet-upload-staged-guard
branch
from
314b521 to
534856f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Prevent a droplet in state STAGED to be downgraded to FAILED
An explanation of the use cases your change solves
If a worker is killed mid-job and restarts, it re-locks and re-runs its own job. When another worker already completed the job in the meantime, the droplet is already STAGED. The rescue block would unconditionally overwrite STAGED with FAILED in that case.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests