Prevent PackageUpload from downgrading a ready package to failed#5245
Open
svkrieger wants to merge 1 commit into
Open
Prevent PackageUpload from downgrading a ready package to failed#5245svkrieger wants to merge 1 commit into
svkrieger wants to merge 1 commit into
Conversation
If a PackageBits job is retried after the worker was restarted mid-job, the retry may fail (e.g. upload file already cleaned up) and call fail_upload!, which would downgrade a READY package back to FAILED. Guard against this by checking the current state inside the DB transaction after acquiring the row lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
Add guard against package downgrade by checking the current state inside the DB transaction after acquiring the row lock.
An explanation of the use cases your change solves
If a PackageBits job is retried after the worker was restarted mid-job, the retry may fail (e.g. upload file already cleaned up) and call fail_upload!, which would downgrade a READY package back to FAILED.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests