Skip to content

build(deps-dev): bump rubocop from 1.89.0 to 1.90.0 #5403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johha merged 2 commits into from
Sep 1, 2026
Merged

build(deps-dev): bump rubocop from 1.89.0 to 1.90.0 #5403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c880e4
build(deps-dev): bump rubocop from 1.89.0 to 1.90.0
dependabot[bot] Aug 28, 2026
245108b
Fix rubocop issues
johha Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ group :test do
gem 'rspec-its'
gem 'rspec-rails', '~> 8.0.4'
gem 'rspec-wait'
gem 'rubocop', '~> 1.89.0'
gem 'rubocop', '~> 1.90.0'
gem 'rubocop-capybara'
gem 'rubocop-factory_bot'
gem 'rubocop-rails', '~> 2.37'
Expand Down
6 changes: 3 additions & 3 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@ GEM
activesupport (>= 3.0.0)
mustache (~> 1.0, >= 0.99.4)
rspec (~> 3.0)
rubocop (1.89.0)
json (~> 2.3)
rubocop (1.90.0)
json (>= 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (>= 1.10)
Expand Down Expand Up @@ -479,7 +479,7 @@ DEPENDENCIES
rspec-rails (~> 8.0.4)
rspec-wait
rspec_api_documentation (>= 6.1.0)
rubocop (~> 1.89.0)
rubocop (~> 1.90.0)
rubocop-capybara
rubocop-factory_bot
rubocop-rails (~> 2.37)
Expand Down
2 changes: 1 addition & 1 deletion app/messages/role_create_message.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def user_origin
end

def user_guid
HashUtils.dig(user, :data, :guid)
HashUtils.dig(user, :data, :guid)
end

def space_guid
Expand Down
4 changes: 2 additions & 2 deletions app/repositories/event_types.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ class EventTypesError < StandardError
SERVICE_ROUTE_BINDING_CREATE = 'audit.service_route_binding.create'.freeze,
SERVICE_ROUTE_BINDING_UPDATE = 'audit.service_route_binding.update'.freeze,
SERVICE_ROUTE_BINDING_DELETE = 'audit.service_route_binding.delete'.freeze,
SERVICE_ROUTE_BINDING_START_CREATE = 'audit.service_route_binding.start_create'.freeze,
SERVICE_ROUTE_BINDING_START_DELETE = 'audit.service_route_binding.start_delete'.freeze,
SERVICE_ROUTE_BINDING_START_CREATE = 'audit.service_route_binding.start_create'.freeze,
SERVICE_ROUTE_BINDING_START_DELETE = 'audit.service_route_binding.start_delete'.freeze,

USER_PROVIDED_SERVICE_INSTANCE_CREATE = 'audit.user_provided_service_instance.create'.freeze,
USER_PROVIDED_SERVICE_INSTANCE_UPDATE = 'audit.user_provided_service_instance.update'.freeze,
Expand Down
4 changes: 2 additions & 2 deletions lib/cloud_controller/benchmark/blobstore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ class Blobstore
'0.01MB' => (0.01 * 1024 * 1024).to_i,
'0.1MB' => (0.1 * 1024 * 1024).to_i,
'1MB' => 1 * 1024 * 1024,
'10MB' => 10 * 1024 * 1024,
'50MB' => 50 * 1024 * 1024,
'10MB' => 10 * 1024 * 1024,
'50MB' => 50 * 1024 * 1024,
'100MB' => 100 * 1024 * 1024,
'500MB' => 500 * 1024 * 1024,
'1000MB' => 1000 * 1024 * 1024
Expand Down
2 changes: 1 addition & 1 deletion lib/cloud_controller/blobstore/error_handling_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def cp_file_between_keys(*)
end

def cp_r_to_blobstore(*)
error_handling { wrapped_client.cp_r_to_blobstore(*) }
error_handling { wrapped_client.cp_r_to_blobstore(*) }
end

def download_from_blobstore(*, **)
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/controllers/services/user_provided_service_instances_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,8 +598,8 @@ def self.user_sees_empty_enumerate(user_role, member_a_ivar, member_b_ivar)
context 'when the updated service instance name is taken' do
let(:service_instance_attrs_foo) { { name: 'foo', space: space } }
let(:service_instance_attrs_bar) { { name: 'bar', space: space } }
let(:service_instance_foo) { create(:user_provided_service_instance, service_instance_attrs_foo) }
let(:service_instance_bar) { create(:user_provided_service_instance, service_instance_attrs_bar) }
let(:service_instance_foo) { create(:user_provided_service_instance, service_instance_attrs_foo) }
let(:service_instance_bar) { create(:user_provided_service_instance, service_instance_attrs_bar) }

it 'fails and returns service instance name is taken' do
put "/v2/user_provided_service_instances/#{service_instance_foo.guid}",
Expand Down
4 changes: 2 additions & 2 deletions spec/unit/models/runtime/process_model_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ def expect_no_validator(validator_class)

context 'with sidecars' do
let(:process) { ProcessModelFactory.make }
let(:sidecar1) { create(:sidecar_model, app: process.app) }
let(:sidecar2) { create(:sidecar_model, app: process.app) }
let(:sidecar1) { create(:sidecar_model, app: process.app) }
let(:sidecar2) { create(:sidecar_model, app: process.app) }
let(:other_sidecar) { create(:sidecar_model, app: process.app) }

before do
Expand Down
Loading