Skip to content

Add jorbaum as Logging and Metrics Approver - #1595

Merged
ameowlia merged 1 commit into
cloudfoundry:mainfrom
jorbaum:jorbaum-lgtm-approver
Sep 3, 2026
Merged

Add jorbaum as Logging and Metrics Approver#1595
ameowlia merged 1 commit into
cloudfoundry:mainfrom
jorbaum:jorbaum-lgtm-approver

Conversation

@jorbaum

@jorbaum jorbaum commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chombium chombium left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorbaum has done some great work in the Logging and Metrics Team and is deeply involved in maintaining and adding new features to the Loggregator components which we maintain.

@beyhan

beyhan commented Aug 3, 2026

Copy link
Copy Markdown
Member

We will require two approvals (thumps up, +1 comment,...) from the @cloudfoundry/wg-app-runtime-platform-logging-and-metrics-approvers because we have definitely more than four approvers in the area.

ping: @cloudfoundry/wg-app-runtime-platform-logging-and-metrics-approvers

Just providing @jorbaum contributions generated by the contributions-for-user.sh

App Runtime Platform: Logging and Metrics Contributions

PRs Commented on/Reviewed:

Issues that may be relevant:

Code contributions:

@beyhan beyhan added the wg-arp label Aug 3, 2026
@chombium

Copy link
Copy Markdown
Contributor

We will require two approvals (thumps up, +1 comment,...) from the @cloudfoundry/wg-app-runtime-platform-logging-and-metrics-approvers because we have definitely more than four approvers in the area.

@beyhan There are more approvers in this area, but I'm the only one active. IMO it will be hard to get another approval.

@selzoc selzoc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to give a +1 - frankly I was surprised that @jorbaum wasn't already an approver!

@chombium

Copy link
Copy Markdown
Contributor

@selzoc Thank you for your support and help. @jorbaum is doing some great things lately indeed, but we wanted to get the one more substantial PR merged which we've done.

@beyhan

beyhan commented Sep 2, 2026

Copy link
Copy Markdown
Member

@ameowlia this looks ready for merging.

@beyhan
beyhan requested a review from ameowlia September 2, 2026 08:31
@ameowlia
ameowlia merged commit a5a8a0b into cloudfoundry:main Sep 3, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from Inbox to Done in CF Community Sep 3, 2026
@jorbaum
jorbaum deleted the jorbaum-lgtm-approver branch September 3, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants