Repository navigation
Enable mTLS configuration for ssh_proxy job - #1215
Open
jochenehret wants to merge 4 commits into
Open
jochenehret wants to merge 4 commits into
jochenehret wants to merge 4 commits into
Conversation
This was referenced Oct 5, 2026
4 of 5 tasks
ameowlia
requested changes
Oct 16, 2026
Member
There was a problem hiding this comment.
Overall looks good, just some small changes please.
-
You changed go code, but there are no go tests. Please add tests.
-
Invalid mTLS config (missing one of tls_port/ca_cert/client_cert/client_key) silently falls back to plain HTTP instead of erroring. This should cause errors asap. There should be basic validation in the template, and more complex validation in go.
-
Give this new ca its own cert file instead of appending it to cc_api_ca_cert.
-
add template tests for the new ca file since it has logic in it.
Ping me in slack when you make these changes so I can re-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable mTLS connection from ssh-proxy job to cloud controller (instead of plain http).
cloudfoundry/capi-release#701
cloudfoundry/cf-deployment#1381
Backward Compatibility
Breaking Change? No