Repository navigation
Conversation
| UsageDetails: plugin.Usage{ | ||
| Usage: `Deploy a multi-target app using blue-green deployment | ||
| cf bg-deploy MTA [-e EXT_DESCRIPTOR[,...]] [-t TIMEOUT] [--version-rule VERSION_RULE] [-u URL] [-f] [--retries RETRIES] [--no-start] [--namespace NAMESPACE] [--apply-namespace-app-names true/false] [--apply-namespace-service-names true/false] [--apply-namespace-app-routes true/false] [--apply-namespace-as-suffix true/false ] [--delete-services] [--delete-service-keys] [--delete-service-brokers] [--keep-files] [--no-restart-subscribed-apps] [--no-confirm] [--skip-idle-start] [--do-not-fail-on-missing-permissions] [--abort-on-error] [--apps-start-timeout TIMEOUT] [--apps-stage-timeout TIMEOUT] [--apps-upload-timeout TIMEOUT] [--apps-task-execution-timeout TIMEOUT] | ||
| cf bg-deploy MTA [-e EXT_DESCRIPTOR[,...]] [-t TIMEOUT] [--version-rule VERSION_RULE] [-u URL] [-f] [--retries RETRIES] [--no-start] [--namespace NAMESPACE] [--apply-namespace-app-names true/false] [--apply-namespace-service-names true/false] [--apply-namespace-app-routes true/false] [--apply-namespace-as-suffix true/false ] [--delete-services] [--delete-service-keys] [--delete-service-brokers] [--keep-files] [--no-restart-subscribed-apps] [--no-confirm] [--skip-idle-start] [--do-not-fail-on-missing-permissions] [--abort-on-error] [--apps-start-timeout TIMEOUT] [--apps-stage-timeout TIMEOUT] [--apps-upload-timeout TIMEOUT] [--apps-task-execution-timeout TIMEOUT] [--services-create-service-timeout TIMEOUT] [--services-bind-service-timeout TIMEOUT] [--services-create-service-key-timeout TIMEOUT] |
Contributor
There was a problem hiding this comment.
maybe align with apps:
services-create-timeout
services-bind-timeout
services-create-key-timeout
Comment on lines
+53
to
+55
| servicesCreateServiceTimeoutOpt = "services-create-service-timeout" | ||
| servicesBindServiceTimeoutOpt = "services-bind-service-timeout" | ||
| servicesCreateServiceKeyTimeoutOpt = "services-create-service-key-timeout" |
Contributor
There was a problem hiding this comment.
same as above
s-yonkov-yonkov
approved these changes
Nov 5, 2026
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
s-yonkov-yonkov
self-requested a review
November 5, 2026 12:56
s-yonkov-yonkov
requested changes
Nov 5, 2026
s-yonkov-yonkov
left a comment
s-yonkov-yonkov
left a comment
Contributor
There was a problem hiding this comment.
Please validate the three new service timeout options in rollback-mta and add coverage in commands/rollback_mta_command_test.go. Currently, invalid values bypass validation and can abort a conflicting deployment before the controller rejects the rollback request. Test that invalid values are rejected before any abort or operation-start call, and that valid values are forwarded correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LMCROSSITXSADEPLOY-3322