chore: upgrade action runtime to Node 24 - #71
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Action metadata to explicitly run the bundled JavaScript action on the Node 24 runtime, aligning the action with GitHub Actions runner runtime deprecations/migrations.
Changes:
- Switched
runs.usinginaction.ymlfromnode20tonode24.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Note: the |
atmos v1.225.0+ no longer emits atmos_cli_config in 'describe component' output, which this action's tests (and consumers) depend on. See cloudposse/atmos#2933.
|
Root-caused and fixed the pre-existing CI failures in this PR (e92f46b): atmos v1.225.0 removed
|
Atmos editions >= 2026-07-17 (shipped in v1.225.0) default describe.component.filter to 'schema', dropping computed sections like atmos_cli_config from 'atmos describe component' output. The action now sets ATMOS_DESCRIBE_COMPONENT_FILTER=full (respecting an explicit override) so settings-paths keep resolving on any atmos version; the CI atmos-version pin is reverted. Verified against atmos 1.224.0, 1.225.0, and 1.226.0-rc.6 (9/9 tests pass on each).
|
Update per review feedback — the earlier version-pin is gone; this is edition-gated behavior with a supported knob, not a hard regression (3926b9d):
Tracking issue cloudposse/atmos#2933 updated accordingly. (Separate note for maintainers: |
|
Phase-2 follow-up now that cloudposse/.github#261 is merged: the repo's own workflow pins are bumped to Node 24 runtimes, SHA-pinned ( |
|
These changes were released in v2.0.3. |
what
node20tonode24inaction.ymlwhy
runs.using: node20emit adeprecation warning for every consumer and are already being force-migrated to Node 24
node24makes the migration deliberate rather than implicitdist/bundle is unchanged (no source changes, socheck-diststill matches);it was smoke-tested locally under Node 24, and this repo's integration tests exercise the bundle
end-to-end via
uses: ./on this PR, now running on Node 24references