Repository navigation
chore: remove node_modules, bundle with ncc, and upgrade to Node 24 - #80
Closed
Kevin (kevcube) wants to merge 1 commit into
Closed
Kevin (kevcube) wants to merge 1 commit into
Kevin (kevcube) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
node_modules/from version control, addnode_modules/to.gitignore, and bundle the action intodist/using@vercel/nccaction.ymlfromnode20/index.jstonode24/dist/index.js@actions/artifactto^6.3.1,@actions/coreto^3.0.1,yamlto^2.9.1), remove unusedcrypto,fs, andtmppackages, andawaitartifactClient.uploadArtifact()actions/checkout@v4->actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1actions/download-artifact@v4->actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2nick-fields/assert-action@v2->nick-fields/assert-action@0efd6166067d9c59d89c710fab4f79fb066f8985 # v4.0.1.github/workflows/test-special-chars.yml(workflow_dispatch.inputsmissing newlines on lines 13 and 16)why
node_modules/bloats the repository and causes massive diffs on dependency updates; bundling intodist/via@vercel/nccmatches standard GitHub Action best practices and other Cloud Posse JS/TS actions@actions/artifactv6+ andactions/download-artifactv8+ ensure compatibility with the current GitHub Actions artifact backend and Node 24test-special-chars.ymlhad malformed YAML inon.workflow_dispatch.inputs, causing GitHub to rejectworkflow_dispatchtriggers in CI with HTTP 422references