fix(release): prevent release if tag major/minor isnt in metadata.yaml - #90
Merged
Merged
Conversation
disperate
reviewed
Sep 22, 2026
| os.Exit(1) | ||
| } | ||
| if err := verifyReleaseSeries(*tag, metadata); err != nil { | ||
| fmt.Fprintf(os.Stderr, "Error verifying release metadata: %v\n", err) |
Contributor
There was a problem hiding this comment.
This message could be improved: The verification here actually succeeded in finding a mismatch. Consider "Release metadata verification failed: %v\n" to avoid making it sound like an internal tool error.
| tag: "v1.1.0", | ||
| metadata: "releaseSeries: [\n", | ||
| wantError: "parse metadata", | ||
| }, |
Contributor
There was a problem hiding this comment.
Another error case we are handling but there is no test yet:
{
name: "empty release series fails",
tag: "v1.0.0",
metadata: "releaseSeries: []\n",
wantError: "no release series",
},
Collaborator
Author
There was a problem hiding this comment.
fair enough, added that test.
mweibel
force-pushed
the
verify-release-manifests
branch
from
September 22, 2026 08:44
af30502 to
5a32783
Compare
disperate
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.