Skip to content

refactor: hoist static values outside per-line render loop #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pan-kot merged 1 commit into from
Sep 28, 2026
Merged

refactor: hoist static values outside per-line render loop #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/code-view/internal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ const ACE_CLASSES = { light: "ace-cloud_editor", dark: "ace-cloud_editor_dark" }
// Static props objects to avoid recreation on every render.
const REGION_PROPS = { role: "region" } as const;
const NO_REGION_PROPS = {} as const;
const SHRINK_COL_STYLE = { width: 1 } as const;
const AUTO_COL_STYLE = { width: "auto" } as const;

const lineNumberClassName = clsx(styles["line-number"], styles.unselectable);

type InternalCodeViewProps = CodeViewProps & InternalBaseComponentProps;

Expand Down Expand Up @@ -57,6 +61,10 @@ export function InternalCodeView({
// Memoize tokenized React nodes to avoid re-running highlight on every render.
const code = useMemo(() => (highlight ? highlight(content) : textHighlight(content)), [content, highlight]);
const codeElement = Children.only(code) as ReactElement;
const codeLineClassName = clsx(
codeElement.props.className,
wrapLines ? styles["code-line-wrap"] : styles["code-line-nowrap"],
);

return (
<div
Expand All @@ -78,8 +86,8 @@ export function InternalCodeView({
)}
>
<colgroup>
<col style={{ width: 1 } /* shrink to fit content */} />
<col style={{ width: "auto" }} />
<col style={SHRINK_COL_STYLE} />
<col style={AUTO_COL_STYLE} />
</colgroup>
{accessibleLineNumbers && (
<thead className={styles["screenreader-only"]}>
Expand All @@ -94,25 +102,15 @@ export function InternalCodeView({
return (
<tr key={index}>
{lineNumbers && (
<td
className={clsx(styles["line-number"], styles.unselectable)}
aria-hidden={!accessibleLineNumbers}
>
<td className={lineNumberClassName} aria-hidden={!accessibleLineNumbers}>
<Box variant="code" color="text-status-inactive" fontSize="body-m">
{index + 1}
</Box>
</td>
)}
<td className={styles["code-line"]}>
<Box variant="code" fontSize="body-m">
<span
className={clsx(
codeElement.props.className,
wrapLines ? styles["code-line-wrap"] : styles["code-line-nowrap"],
)}
>
{child}
</span>
<span className={codeLineClassName}>{child}</span>
</Box>
</td>
</tr>
Expand Down
Loading