Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5073 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 990 990
Lines 31818 31821 +3
Branches 11752 11755 +3
=======================================
+ Hits 31089 31092 +3
Misses 722 722
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pan-kot
force-pushed
the
chore-popover-and-tooltip-style-v2
branch
3 times, most recently
from
September 30, 2026 14:01
290a2aa to
ea694db
Compare
pan-kot
marked this pull request as ready for review
September 30, 2026 14:02
pan-kot
force-pushed
the
chore-popover-and-tooltip-style-v2
branch
from
September 30, 2026 16:17
ea694db to
9f7ee0b
Compare
pan-kot
had a problem deploying
to
allure-report
September 30, 2026 17:17 — with 
GitHub Actions
Failure
GitHub Actions
Failure
pan-kot
marked this pull request as draft
October 6, 2026 14:51
pan-kot
force-pushed
the
chore-popover-and-tooltip-style-v2
branch
from
October 7, 2026 14:01
9f7ee0b to
3a386c2
Compare
pan-kot
force-pushed
the
chore-popover-and-tooltip-style-v2
branch
from
October 7, 2026 14:06
3a386c2 to
5a1f92f
Compare
pan-kot
marked this pull request as ready for review
October 7, 2026 14:06
pan-kot
requested a deployment
to
allure-report
October 7, 2026 15:01 — with
GitHub Actions
In progress
GitHub Actions
In progress
pan-kot
marked this pull request as draft
October 19, 2026 08:51
vvaliyev
reviewed
Oct 19, 2026
| @use '../style-api/palette' as palette; | ||
|
|
||
| .popover-brand { | ||
| --awsui-style-color: #{palette.$genai-text}; |
Member
There was a problem hiding this comment.
we don't have such a token for popover at the moment
vvaliyev
reviewed
Oct 19, 2026
| .body { | ||
| @include styles.styles-reset; | ||
| @include styles.text-flex-wrapping; | ||
| color: awsui.$color-text-body-default; |
vvaliyev
reviewed
Oct 19, 2026
|
|
||
| // Style API v2 | ||
| interface StyleClassNames { | ||
| popover?: string; |
Member
There was a problem hiding this comment.
I'm having second thoughts about this naming, and now more inclined to calling this root for 2 reasons:
- A slot is the thing you style, named from the component's point of view. For Popover, the thing you style is the popover box, which from the component's perspective is its main surface.
- The mixin name that we want to add: popover.popover(...) reads badly
What do you think about calling this root?
vvaliyev
reviewed
Oct 19, 2026
| "properties": [], | ||
| "propertyDescriptions": {}, | ||
| "tokenDescriptions": { | ||
| "background": "Background of the surface and arrow.", |
Member
There was a problem hiding this comment.
this token is called background-color in our tracker. What is the reason to change?
Member
Author
|
Closed in favour of #5175 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds internal style api v2 support to popover and tooltip components.
API: 0H95IVsMSJG2
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.