Repository navigation
test: Add visual tests for the CopyToClipboard One Theme glyph swap - #5169
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5169 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 998 998
Lines 32294 32294
Branches 11945 11944 -1
=======================================
Hits 31564 31564
- Misses 685 724 +39
+ Partials 45 6 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/override-visual-regression New visual definitions for copy-to-clipboard/motion |
ywyyu17
marked this pull request as ready for review
October 28, 2026 13:45
ywyyu17
requested review from
ernst-dev and
mxschll
and removed request for
a team and
ernst-dev
October 28, 2026 13:45
mxschll
reviewed
Oct 28, 2026
| setup: async ({ page }) => { | ||
| await page.click(triggerSelector(testId)); | ||
| // Wait out the popover's settle animation so it is captured at rest. | ||
| await page.waitForJsTimers(300); |
Member
There was a problem hiding this comment.
As a follow up: can we make the "disable motion" feature work properly so we don't need this timer? Currently, only sets some css timing to 0 globally, which does not actually disable all motion.
mxschll
approved these changes
Oct 28, 2026
ywyyu17
enabled auto-merge
October 28, 2026 14:06
Contributor
Author
|
/override-visual-regression New visual definitions for copy-to-clipboard/motion |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #5157, which added the One Theme glyph swap to CopyToClipboard and the copy-to-clipboard/motion dev page. This adds visual regression coverage for the swapped end state.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.