[pan-kot]

Description

Makes token component use internal button instead of a custom dismiss button implementation. The change is done in preparation of adding styling v2 support: it is not a requirement, but it helps to make styling implementation simpler.

How has this been tested?

• Manual testing
• Existing visual regression tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

• Changes include appropriate documentation updates.
• Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
• Changes do not include unsupported browser features, see CONTRIBUTING.md.
• Changes were manually tested for accessibility, see accessibility guidelines.

Security

• If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

• Changes are covered with new/existing unit tests?
• Changes are covered with new/existing integration tests?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (e82bbc0) to head (cb073e6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5189      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files         998      998              
  Lines       32291    32287       -4     
  Branches    11941    11939       -2     
==========================================
- Hits        31561    31557       -4     
+ Misses        724      685      -39     
- Partials        6       45      +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

🟡 Changes recommended

The refactor changes pressed-state dismiss colors for unstyled and partially styled tokens.

1 open issue

• Preserve dismiss button colors during active state · New

What changed in this PR

Refactors token dismissal to use the shared internal button, reducing custom implementation ahead of styling v2 support.

Changes:

• Replaces the custom dismiss button with InternalButton.
• Maps token dismiss styles to button styles and isolates inherited styling properties.
• Updates style, motion, and analytics tests for the shared implementation.

File	Description
src/​token/​styles.tsx	Maps dismiss styles to the button style API.
src/​token/​styles.scss	Preserves token-specific button geometry and focus styling.
src/​token/​internal.tsx	Passes token styles to the dismiss button.
src/​token/​dismiss-button.tsx	Replaces custom markup with InternalButton.
src/​token/​__tests__/​token.test.tsx	Updates motion attribute expectations.
src/​token/​__tests__/​styles.test.tsx	Tests dismiss style mapping and state precedence.
src/​token/​__tests__/​analytics-metadata.test.tsx	Checks exact dismiss analytics metadata.
src/​token/​__tests__/​__snapshots__/​styles.test.tsx.snap	Removes dismiss styles from root snapshots.
src/​internal/​styles/​forms/​mixins.scss	Adds a reset for inherited button styling properties.

_{Review effort: Balanced}

[pan-kot]

Good comment. The new behaviour is indeed different from the previous custom dismiss button implementation. At the same time - it is consistent with icon button's default implementation - so also reproducible in standalone buttons or e.g. in Alert/Flashbar dismiss. I believe we should keep it therefore for consistency, and if we want a design change - apply it for all icon buttons, not just token dismiss.