Repository navigation
chore: Adds internal style api v2 to text filter, date input and time input - #5198
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5198 +/- ##
=======================================
Coverage 97.73% 97.74%
=======================================
Files 998 1000 +2
Lines 32294 32314 +20
Branches 11945 11953 +8
=======================================
+ Hits 31564 31584 +20
Misses 685 685
Partials 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Duplicated Input styling across DateInput, TimeInput, and TextFilter demos should be extracted into shared Sass mixins to avoid repeating fixes, with component-specific overrides kept local.
1 open issue
What changed in this PR
Adds internal Style API v2 support to TextFilter, DateInput, and TimeInput by forwarding Input styling slots, without changing public props or default component styling.
Changes:
- Forwards Input style classes and adds TextFilter’s
countTextslot. - Supports whole-component documentation forwards and refreshes style-docs snapshots.
- Adds unit tests and styled demo pages for the three components.
| File | Description |
|---|---|
src/time-input/styles.scss |
Documents the Input forward. |
src/time-input/internal.tsx |
Forwards internal Input style classes. |
src/time-input/__tests__/style-api.test.tsx |
Tests forwarding, states, and DOM prop isolation. |
src/text-filter/styles.scss |
Documents Input forwarding and countText styling. |
src/text-filter/search-results.tsx |
Applies a custom results-count class. |
src/text-filter/internal.tsx |
Routes Input and count-text style classes. |
src/text-filter/__tests__/style-api.test.tsx |
Tests slot classes, disabled behavior, and prop isolation. |
src/internal/styles/style-api.scss |
Makes the forwarded slot optional. |
src/date-input/styles.scss |
Documents the Input forward. |
src/date-input/internal.tsx |
Forwards internal Input style classes. |
src/date-input/__tests__/style-api.test.tsx |
Tests forwarding, states, and DOM prop isolation. |
src/__tests__/snapshot-tests/__snapshots__/style-docs.test.ts.snap |
Adds component entries and refreshes property lists. |
pages/time-input/style-api-v2.scss |
Defines demo styling through Input mixins. |
pages/time-input/style-api-v2.page.tsx |
Demonstrates TimeInput styling across states and formats. |
pages/text-filter/style-api-v2.scss |
Styles Input slots and results count. |
pages/text-filter/style-api-v2.page.tsx |
Demonstrates TextFilter styling and count visibility. |
pages/date-input/style-api-v2.scss |
Defines demo styling through Input mixins. |
pages/date-input/style-api-v2.page.tsx |
Demonstrates DateInput styling across states and formats. |
Review effort: Balanced
vvaliyev
force-pushed
the
style-v2-input-forwards
branch
from
October 28, 2026 12:12
9205218 to
dd5460e
Compare
vvaliyev
marked this pull request as ready for review
October 28, 2026 13:01
pan-kot
reviewed
Oct 28, 2026
pan-kot
previously approved these changes
Oct 28, 2026
vvaliyev
enabled auto-merge
October 28, 2026 13:55
vvaliyev
force-pushed
the
style-v2-input-forwards
branch
from
October 28, 2026 14:23
dd5460e to
b8e21ab
Compare
vvaliyev
force-pushed
the
style-v2-input-forwards
branch
from
October 28, 2026 14:31
b8e21ab to
aca68ec
Compare
pan-kot
previously approved these changes
Oct 29, 2026
vvaliyev
disabled auto-merge
October 29, 2026 10:23
vvaliyev
force-pushed
the
style-v2-input-forwards
branch
from
October 29, 2026 10:29
aca68ec to
b69a1a3
Compare
pan-kot
approved these changes
Oct 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds the internal Style API v2 to Text filter, Date input and Time input. All three render an Input, and each exposes it as a whole-component forward: the
inputslot takes Input's style class names object ({ root, input, inlineLabel, searchIcon, clearButton }) and consumers style it through the generated Input mixins. Text filter additionally has its owncountTextslot (the results count rendered after the input; shown whilefilteringTextandcountTextare set and the filter is not disabled) withcolor,font-family,font-size,font-weight.The
styleClassNamesprops are internal and not part of the public props. Design-token values and the v1 inline styles are unchanged; no CSS changes.The style-docs snapshot is regenerated with component-toolkit
1.0.0-beta.192, which lists shorthand properties as their longhands; the existing entries for Alert, Badge, Button, Dropdown, Input and Textarea change accordingly, and the three new entries are added. The generatedstyling/date-input.scssandstyling/time-input.scsscontain no mixins because these components only forward.Tracker sections: P3d34KdbCd6o.
How has this been tested?
npm run build; unit tests forsrc/text-filter,src/date-input,src/time-input,src/input, the masked input, and the style-docs snapshot; prettier, stylelint, eslint.countTextclass lands on the count element and is absent when the count is not shown, unknown keys are ignored, the prop does not reach the DOM.pages/{text-filter,date-input,time-input}/style-api-v2styled only through the generatedinput.root(),input.input(),input.searchIcon(),button.root()andtext-filter.countText()mixins, covering the documented states; checked in the browser. Not in the visual regression suite yet, like the otherstyle-api-v2pages.