Repository navigation
feat: Add chart zoom i18n messages - #5199
Merged
Merged
Conversation
Add the 16 zoom strings to the [charts] messages and their types, from the i18n package output. Arabic and Thai translations are not available yet.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The German translation omits a space before {value} and incorrectly instructs users to enter the Enter key rather than press it.
1 open issue
What changed in this PR
Adds chart zoom messages to Cloudscape’s shared internationalization resources, covering control labels and screen-reader announcements.
Changes:
- Adds 16 zoom strings to each of 13 locale bundles; Arabic and Thai translations remain pending.
- Extends message types with the new keys and typed interpolation arguments.
| File | Description |
|---|---|
src/i18n/messages/all.zh-TW.json |
Adds Traditional Chinese zoom messages. |
src/i18n/messages/all.zh-CN.json |
Adds Simplified Chinese zoom messages. |
src/i18n/messages/all.tr.json |
Adds Turkish zoom messages. |
src/i18n/messages/all.pt-BR.json |
Adds Brazilian Portuguese zoom messages. |
src/i18n/messages/all.ko.json |
Adds Korean zoom messages. |
src/i18n/messages/all.ja.json |
Adds Japanese zoom messages. |
src/i18n/messages/all.it.json |
Adds Italian zoom messages. |
src/i18n/messages/all.id.json |
Adds Indonesian zoom messages. |
src/i18n/messages/all.fr.json |
Adds French zoom messages. |
src/i18n/messages/all.es.json |
Adds Spanish zoom messages. |
src/i18n/messages/all.en.json |
Adds English zoom messages. |
src/i18n/messages/all.en-GB.json |
Adds British English zoom messages. |
src/i18n/messages/all.de.json |
Adds German zoom messages. |
src/i18n/messages-types.ts |
Defines zoom message keys and interpolation argument types. |
Review effort: Balanced
amanabiy
approved these changes
Oct 28, 2026
srungta08
enabled auto-merge
October 28, 2026 11:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5199 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 998 998
Lines 32291 32291
Branches 11941 11942 +1
=======================================
Hits 31561 31561
+ Misses 724 685 -39
- Partials 6 45 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Add the 16 zoom strings to the [charts] messages and their types, from the i18n package output. Arabic and Thai translations are not available yet.
Related links, issue #, if available: n/a
How has this been tested?
N/A
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.