Skip to content

feat: Add chart zoom i18n messages - #5199

Merged
srungta08 merged 1 commit into
mainfrom
dev-v3-srungta-charts-zoom-i18n
Oct 28, 2026
Merged

srungta08 merged 1 commit into
mainfrom
dev-v3-srungta-charts-zoom-i18n

Conversation

@srungta08

Copy link
Copy Markdown
Member

Description

Add the 16 zoom strings to the [charts] messages and their types, from the i18n package output. Arabic and Thai translations are not available yet.

Related links, issue #, if available: n/a

How has this been tested?

N/A

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add the 16 zoom strings to the [charts] messages and their types, from
the i18n package output. Arabic and Thai translations are not available
yet.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The German translation omits a space before {value} and incorrectly instructs users to enter the Enter key rather than press it.

1 open issue
What changed in this PR

Adds chart zoom messages to Cloudscape’s shared internationalization resources, covering control labels and screen-reader announcements.

Changes:

  • Adds 16 zoom strings to each of 13 locale bundles; Arabic and Thai translations remain pending.
  • Extends message types with the new keys and typed interpolation arguments.
File Description
src/​i18n/​messages/​all.zh-TW.json Adds Traditional Chinese zoom messages.
src/​i18n/​messages/​all.zh-CN.json Adds Simplified Chinese zoom messages.
src/​i18n/​messages/​all.tr.json Adds Turkish zoom messages.
src/​i18n/​messages/​all.pt-BR.json Adds Brazilian Portuguese zoom messages.
src/​i18n/​messages/​all.ko.json Adds Korean zoom messages.
src/​i18n/​messages/​all.ja.json Adds Japanese zoom messages.
src/​i18n/​messages/​all.it.json Adds Italian zoom messages.
src/​i18n/​messages/​all.id.json Adds Indonesian zoom messages.
src/​i18n/​messages/​all.fr.json Adds French zoom messages.
src/​i18n/​messages/​all.es.json Adds Spanish zoom messages.
src/​i18n/​messages/​all.en.json Adds English zoom messages.
src/​i18n/​messages/​all.en-GB.json Adds British English zoom messages.
src/​i18n/​messages/​all.de.json Adds German zoom messages.
src/​i18n/​messages-types.ts Defines zoom message keys and interpolation argument types.

Review effort: Balanced

Comment thread src/i18n/messages/all.de.json
@srungta08
srungta08 enabled auto-merge October 28, 2026 11:39
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (e82bbc0) to head (94a9614).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5199   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         998      998           
  Lines       32291    32291           
  Branches    11941    11942    +1     
=======================================
  Hits        31561    31561           
+ Misses        724      685   -39     
- Partials        6       45   +39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@srungta08
srungta08 added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 8000025 Oct 28, 2026
71 checks passed
@srungta08
srungta08 deleted the dev-v3-srungta-charts-zoom-i18n branch October 28, 2026 12:21

This branch was successfully deployed

3 active deployments
dev-pages-react16 — 94a96148 Deployed Oct 28, 2026 by srungta08 via deploy (React 16) / deploy #3012
dev-pages-react18 — 94a96148 Deployed Oct 28, 2026 by srungta08 via deploy (React 18) / deploy #3012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants