Skip to content

chore: Remove icon provider from autosuggest dev page - #5201

Merged
jperals merged 1 commit into
mainfrom
chore/remove-icon-provider-in-dev-page
Oct 29, 2026
Merged

jperals merged 1 commit into
mainfrom
chore/remove-icon-provider-in-dev-page

Conversation

@jperals

@jperals jperals commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Description

Otherwise the page cannot be rendered in systems that do not include this component.

How has this been tested?

The page still renders with the rest of permutations: link

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (2f15b03) to head (a433a26).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5201   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         998      998           
  Lines       32290    32290           
  Branches    11941    11941           
=======================================
  Hits        31560    31560           
  Misses        724      724           
  Partials        6        6           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals

jperals commented Oct 28, 2026

Copy link
Copy Markdown
Member Author

/override-visual-regression Fails because mismatch in number of permutations, since one was removed

@jperals
jperals marked this pull request as ready for review October 29, 2026 07:48
@jperals
jperals requested a review from a team as a code owner October 29, 2026 07:48
@jperals
jperals requested review from NathanZlion and removed request for a team October 29, 2026 07:48
@jperals
jperals enabled auto-merge October 29, 2026 07:49
@jperals
jperals added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit 26bf75b Oct 29, 2026
89 of 92 checks passed
@jperals
jperals deleted the chore/remove-icon-provider-in-dev-page branch October 29, 2026 08:52

This branch was successfully deployed

3 active deployments
dev-pages-react16 — a433a263 Deployed Oct 28, 2026 by jperals via deploy (React 16) / deploy #3033
dev-pages-react18 — a433a263 Deployed Oct 28, 2026 by jperals via deploy (React 18) / deploy #3033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants