Skip to content

[governor] 🐝 Hive Advisory Report #388

Open

Description

@hivecommons-hive

This issue collects advisory findings from Hive agents.

At lower ACMM levels, some agents work in advisory mode β€” they analyze code and post findings here but do not create issues or PRs. At higher levels, designated agents (e.g. quality) can open issues and PRs directly, while other agents remain advisory-only.

The governor posts periodic digest comments summarizing what advisory agents found.

Do not close this issue. It is a living document.

β€” hive: agent=governor

Activity

  1. hivecommons-hive commented on Nov 10, 2026

    @hivecommons-hive
    ContributorAuthor

    🐝 Advisory Digest β€” 2026-11-18 16:28 EST

    Automated code review findings from Hive agents. Each finding includes a file reference and suggested fix. This comment is updated periodically.

    Advice

    Frozen for governor mode QUIET until 2026-11-19 (next review in 1 day(s)). The list of recommendations is frozen; their numbers, items and links are recomputed on every digest.

    Counts quoted: governor actionable queue 2 PRs / 6 issues (what mode and cadence key on; excludes held, draft, in-review and human-gated items) β€” Overview chart 6 open PRs / 35 open issues (every open or held item across repo cards; the queue-health advice counts these).

    • Reduce the blocked PR queue β€” No longer applies: the signal that triggered this advice has cleared since the epoch began.
    • Clear the human gate on PRs β€” 4 of 6 open PRs (66%) wait on a human: 4 held, 0 labelled needs-human, 0 needs-decision β€” release, review, or close them. (signals: overview_open_prs=6, needs_human=4, held=4, needs_human_label=0, needs_decision=0)

    Bands named above (same rules as the Overview chart):

    • Needs human (PRs): held, or labelled needs-human, stage/085-needs-decision, needs-decision, 2-discussing, blocked, stage/045-needs-decision, epic, needs-triage β€” a human must review, decide, or release the hold before automation continues

    Findings: 10

    πŸ’‘ Showing top 10 findings (by severity). 79 more exist. Set governor.advisory.show_all: true to see all.

    Severity Count
    🟠 high 10

    🟠 HIGH (10)

    • [coverage-gap] docusaurus.config.ts isProd-dependent url/editUrl branches had no unit coverage docusaurus.config.ts quality

      docusaurus.config.ts is excluded from the c8 coverage gate. Its three isProd-dependent fields (top-level url, docs preset editUrl, analyses plugin editUrl) had no unit assertion, and no end-to-end check asserts their values (Netlify deploy-preview only exercises the non-prod branch incidentally, without assertion; the prod branch never runs on PRs at all). Added lib/docusaurusConfigBuildContext.test.mts + test-only harness in PR test: cover isProd-dependent url/editUrl branches in docusaurus.config.tsΒ #413 (cncf/techdocs), tracked under issue [quality] npm run typecheck fails on main β€” merge race between #404 and #405Β #407's component cluster.

    • [coverage-gap] docusaurus.config.ts markdown.preprocessor: reference-style link (]:) branch untested docusaurus.config.ts quality

      markdown.preprocessor regex has two alternatives (inline '](' links and reference-style ']:' link definitions); only the inline branch was unit-tested. Manual mutation (deleting the ']:\s*' alternative at rev 418adeb) passed all existing tests, confirming the gap. No e2e/integration suite exists in this repo to provide alternate coverage, so Priority 1. Fixed in PR techdocs#410 (closes issue techdocs#409).

    • [coverage-gap] cncf/techdocs docusaurus.config.ts markdown.preprocessor regex-rewrite has zero test coverage (file path not found at analyzed commit β€” finding may be outdated) (reported 2Γ—) quality

      markdown.preprocessor (docusaurus.config.ts:44-50) runs a regex rewrite (strips .md from site-absolute /docs|analyses links) against the imported root README.md. Unit evidence: lib/**/*.test.mts (node --experimental-strip-types --test) has no test file for docusaurus.config.ts; function is untested. E2E evidence: no e2e/integration suite exists in this repo (checked for playwright/cypress dirs, none found; only format-check/link-check/spell-check CI). Covered by neither unit nor end-to-end tests -> Priority 1 ceiling, set to 2 (medium) given narrow impact (single README.md import path). Provenance: cncf/techdocs main@4b1f800, checked 2026-11-12. Root cause: logic is inlined in docusaurus.config.ts, which imports ./lib/getBuildContext and ./lib/remarkRewriteLinks without file extensions -- fine for docusaurus webpack bundler but unresolvable under this repo's own node --experimental-strip-types test runner (reproduced: ERR_MODULE_NOT_FOUND). Testing it directly therefore requires extracting the regex into its own lib/ module first, which is a production-code change outside quality agent scope (no production code / no refactors). Filed as issue-only; no PR possible without that extraction.

    • [coverage-gap] lib/remarkRewriteLinks/index.ts: 4 branches uncovered by unit tests (89.74% branch coverage) lib/remarkRewriteLinks/index.ts quality

      rewriteHref() in lib/remarkRewriteLinks/index.ts had 4 uncovered branches (c8 --reporter=text on node --experimental-strip-types --test 'lib/**/*.test.mts', local run against HEAD, 2026-11-11): (1) line 87, empty-path-after-split short-circuit (href consisting only of a query/fragment, e.g. '?x'); (2) line 99, the cross-plugin capture group 2 being undefined (a bare '../docs' with no sub-path); (3) line 112, the .mdx branch of the site-absolute strip-extension ternary; (4) line 140, file.path being undefined in the remark plugin wrapper. Repo has no end-to-end/integration suite (CI only runs format-check.yml, link-check.yml, spell-check.yml per [quality] npm run test:unit never runs in CI β€” unit tests have no CI signalΒ #390), so these branches were covered by neither unit nor end-to-end tests -> Priority 1.

    • [missing-workflow] cncf/techdocs: test:e2e also never invoked in CI (same root cause as [quality] Unit tests and coverage gate never run in CIΒ #415) (file path not found at analyzed commit β€” finding may be outdated) quality

      npm run test:e2e (e2e/linkRewrite.test.mjs) builds the site via docusaurus build and passes locally (3/3 tests, ~60s), but like test:unit/test:coverage ([quality] Unit tests and coverage gate never run in CIΒ #415) no CI workflow invokes it. Posted exact replacement test-check.yml YAML (adds parallel e2e-tests job) as a comment on [quality] Unit tests and coverage gate never run in CIΒ #415 rather than opening a 4th workflows-permission-blocked issue, since it is the same root cause/class as [quality] Unit tests and coverage gate never run in CIΒ #415-417. Blocked by the same contributor-tier workflows-permission ceiling; needs a human or ISSUES_PRS_MERGE agent to land.

    • [missing-workflow] cncf/techdocs: unit tests and c8 coverage gate (test:coverage) are never invoked by any CI workflow cncf/techdocs#415 quality

      format-check.yml/link-check.yml/spell-check.yml only run check:format, check:markdown, check:links, check:spelling. package.json 'check' aggregates only check:* scripts. No workflow calls npm run test:unit or npm run test:coverage, so the 52 existing unit tests and the 99/99/97/100 c8 coverage gate enforce nothing on PRs. Fix requires a .github/workflows/ change, which this agent's contributor-tier token cannot push; filed as issue only.

    • [missing-workflow] No CI workflow runs the unit test suite, typecheck, or coverage gate .github/workflows/ (reported 2Γ—) quality

      package.json defines test:unit (52 node:test specs under lib//*.test.mts and scripts//*.test.mjs, including scripts/typecheck.test.mjs which shells out to tsc), test:coverage (c8 wrapping test:unit with a 97-100% coverage gate), and typecheck, but .github/workflows only contains format-check.yml, link-check.yml, spell-check.yml, trigger-contribute-site-netlify.yml, and copilot-setup-steps.yml. None of them run npm run test:unit, npm run test:coverage, or npm run typecheck on pull_request. A regression in any of the 52 unit tests, a drop below the coverage thresholds, or a typecheck break (as happened with the TS5102/TS2339 regression PR test: fix typecheck regression from #404/#405 merge raceΒ #408 fixes) can merge to main without CI ever catching it.

    • [regression-risk] typecheck broken on cncf/techdocs main β€” test: cover docusaurus.config.ts markdown preprocessorΒ #404/test: fix broken typecheck script and add regression testΒ #405 merge race (fixed in PR test: fix typecheck regression from #404/#405 merge raceΒ #408) (file path not found at analyzed commit β€” finding may be outdated) quality

      PR test: cover docusaurus.config.ts markdown preprocessorΒ #404 and test: fix broken typecheck script and add regression testΒ #405 each passed npm run typecheck independently but merged ~2 min apart on cncf/techdocs main; combined, config.markdown.preprocessor destructures from a value typed DeepPartial|undefined once TS5102 no longer masked the error. Fixed with two assert.ok narrowing checks in the test file; filed as issue [quality] npm run typecheck fails on main β€” merge race between #404 and #405Β #407, fix in PR test: fix typecheck regression from #404/#405 merge raceΒ #408 (hold).

    • [test-infrastructure] scripts/test-e2e never invoked by npm test, check, or CI package.json quality

      package.json defines test:e2e (node --test over e2e/.test.mjs, a real docusaurus build against repo content) but nothing invokes it: npm test only runs check && test:unit, npm run check aggregates check: scripts, and no CI workflow calls npm test or test:e2e directly (confirmed: [quality] Unit tests and coverage gate never run in CIΒ #415/[quality] PR-triggered workflows lack concurrency groups, wasting CI minutes on superseded pushesΒ #416/[quality] No coverage-reporting mechanism (trend, badge, regression alert)Β #417 already document that only format/link/spell checks run in CI). Unlike test:unit, which has a guard test (scripts/coverage-thresholds.test.mjs) preventing the gate from silently loosening, nothing protected test:e2e from being dropped or ignored.

    • [test-gap] techdocs#415: npm test:coverage (99/99/97/100 gate) never invoked by any GitHub Actions workflow #415 scanner

      Confirmed independently: .github/workflows/format-check.yml, link-check.yml, and spell-check.yml run check:format/check:markdown/check:links/check:spelling respectively, but no workflow runs 'npm run test:unit' or 'npm run test:coverage' (c8 gate: --lines 99 --statements 99 --branches 97 --functions 100). package.json's aggregate 'check' script only picks up scripts matching check:*, excluding test:unit/test:coverage, so npm test (check && test:unit) is also never invoked in CI. A PR can merge a broken unit test or a coverage regression with all required checks green.

    β˜‘οΈ Recently Closed β€” Fix Not Verified (3)

    Closed on an agent's word or a hive heuristic (a merged PR's title matching the finding, or the issues/PRs it cites closing). The hive did not re-check the condition, so it may still hold.

    • PR Update analysis criteria questionsΒ #423 failing Format/Markdown/Spelling checks on docs/analysis/criteria.md and templates/analysis.md PR#423 format-check.yml,spell-check.yml ci-maintainer β€” closed Nov 18 (no evidence recorded), fix not verified
    • e2e link-rewrite test leaked DEPLOY_PRIME_URL into spawned build env (PR test: add end-to-end coverage for link-rewrite plugins in the real buildΒ #414) e2e/linkRewrite.test.mjs quality β€” closed Nov 17 (the issues/PRs it cites closed), fix not verified
    • techdocs#390: confirmed β€” package.json test:unit script exists but no workflow invokes npm test/test:unit, only format/link/spell checks run in CI, so lib/*.test.mts regressions get green checks #390 scanner β€” closed Nov 16 (the issues/PRs it cites closed), fix not verified

    Analyzed at cncf/techdocs@ff6cca7f6c5a (branch main) β€” the latest commit when this digest was generated. File references that no longer exist at this commit are flagged as outdated. Findings marked ⚠️ were computed at an older commit and have NOT been re-verified here.

    Updated 111 times Β· last 2026-11-18T21:28:30Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions