Repository navigation
test: cover BUILD_ENV=production editUrl/url wiring in e2e link-rewrite suite #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hivecommons-hive
wants to merge
1
commit into
main
Choose a base branch
from
quality/test-e2e-production-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion locks in a broken link. The doubled
analyses/analyses/path is what production currently renders (verified on the live site), but it 404s on GitHub — the file lives atanalyses/2023/backstage/index.md. Mechanism:docusaurus.config.ts:92setseditUrl: ${repo}/tree/main/analyses, and Docusaurus appends the plugin content path on top (compare the docs plugin:editUrl: ${repo}/tree/mainat line 71 renderstree/main/docs/assistance.md). Consequence: every analyses page's "edit this page" link is dead, and this test would fail the eventual fix. Suggest fixing line 92 to${repo}/tree/mainin this PR (plus the config-value assertion inlib/docusaurusConfigBuildContext.test.mts) and asserting the single-analysesURL here.