Skip to content

Commit 0b4691f

Browse files
committed
Fix compile of the github extension
All of our webpack scripts are modules now
1 parent d3c3cf8 commit 0b4691f

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

build/lib/extensions.js

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/lib/extensions.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,9 @@ function updateExtensionPackageJSON(input: Stream, update: (data: any) => any):
6363

6464
function fromLocal(extensionPath: string, forWeb: boolean, disableMangle: boolean): Stream {
6565

66-
const esm = JSON.parse(fs.readFileSync(path.join(extensionPath, 'package.json'), 'utf8')).type === 'module';
67-
6866
const webpackConfigFileName = forWeb
69-
? `extension-browser.webpack.config.${!esm ? 'js' : 'cjs'}`
70-
: `extension.webpack.config.${!esm ? 'js' : 'cjs'}`;
67+
? `extension-browser.webpack.config.js`
68+
: `extension.webpack.config.js`;
7169

7270
const isWebPacked = fs.existsSync(path.join(extensionPath, webpackConfigFileName));
7371
let input = isWebPacked

0 commit comments

Comments
 (0)