terminal.copyOnSelection and terminalFindWidget - do not copy selection on focus (microsoft#254065)

kenherring · anthonykim1 · web-flow · commit 610e0daf065f · 2025-08-13T09:51:35.000-07:00
Co-authored-by: Anthony Kim &lt;62267334+anthonykim1@users.noreply.github.com&gt;
diff --git a/src/vs/workbench/contrib/terminalContrib/find/browser/terminalFindWidget.ts b/src/vs/workbench/contrib/terminalContrib/find/browser/terminalFindWidget.ts
@@ -160,7 +160,7 @@ export class TerminalFindWidget extends SimpleFindWidget {
 	}
 
 	protected _onFocusTrackerFocus() {
-		if ('overrideCopyOnSelection' in this._instance) {
+		if (TerminalClipboardContribution.get(this._instance)?.overrideCopyOnSelection) {
 			this._overrideCopyOnSelectionDisposable = TerminalClipboardContribution.get(this._instance)?.overrideCopyOnSelection(false);
 		}
 		this._findWidgetFocused.set(true);

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ export class TerminalFindWidget extends SimpleFindWidget {`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`protected _onFocusTrackerFocus() {`
`163`		`- if ('overrideCopyOnSelection' in this._instance) {`
	`163`	`+ if (TerminalClipboardContribution.get(this._instance)?.overrideCopyOnSelection) {`
`164`	`164`	`this._overrideCopyOnSelectionDisposable = TerminalClipboardContribution.get(this._instance)?.overrideCopyOnSelection(false);`
`165`	`165`	`}`
`166`	`166`	`this._findWidgetFocused.set(true);`