Repository navigation
Refactored plugin with test framework - #7
Merged
Merged
Conversation
shcherbak
requested changes
Sep 28, 2026
Collaborator
There was a problem hiding this comment.
git update-index --chmod=+x
| # discovery broken in 2.7.4 | ||
| if [[ ! -z "${HELMFILE_DISCOVERY_RESPONSE}" ]]; then | ||
| truthy_test "${HELMFILE_DISCOVERY_RESPONSE}" && { | ||
| # stdout plus exit code 0 means "use this plugin", diagnostics go to stderr_APP_SOURCE_PATH |
Collaborator
There was a problem hiding this comment.
discover: diagnostics go to stderr_APP_SOURCE_PATH - believe this is ctrl-f
Contributor
Author
There was a problem hiding this comment.
it was typo after fixing var names... reverted
| and this project adheres to Semantic Versioning (https://semver.org/). | ||
| --- | ||
|
|
||
| ## [1.3.2] |
Contributor
Author
There was a problem hiding this comment.
version bumped to minor
| - Helm version is detected with `helm version --template '{{.Version}}'` instead of parsing `--short` output. | ||
| - `init` and `generate` fail with a clear error for Helm < 3, helmfile < 1 or unparsable versions. | ||
| - `discover` and `parameters` no longer run `helm`/`helmfile`. | ||
| - Minimum versions: helm >= 3.6, helmfile >= 1 (>= 1.2 with Helm 4). |
Collaborator
There was a problem hiding this comment.
minimum version is 3.19, will not support older
| fi | ||
|
|
||
| if [[ "${HELMFILE_GLOBAL_OPTIONS}" == *-f* ]]; then | ||
| if [[ "${HELMFILE_GLOBAL_OPTIONS:-}" == *--file* || "${HELMFILE_GLOBAL_OPTIONS:-}" == *-f* ]]; then |
Collaborator
There was a problem hiding this comment.
this is old condition and looks suspicious
lets check HELMFILE_GLOBAL_OPTIONS="-e prod-frankfurt"
Contributor
Author
There was a problem hiding this comment.
bug fixed. tests added to check proper behavior
Collaborator
There was a problem hiding this comment.
ok. this should be mentioned in release notes
s-skorobohatko
force-pushed
the
main
branch
from
September 29, 2026 09:35
12d9e02 to
f3cbf66
Compare
s-skorobohatko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test framework (based on bats and shellcheck). Cleanup plugin logic from helm 2. Deleted obsolete or unused code. Fix INCLUDE mode logic