Update dependency dompurify to v3.4.9 [SECURITY]#299
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.4.8→3.4.9DOMPurify: Trusted Types policy survives
clearConfig()and can poison laterRETURN_TRUSTED_TYPEoutputGHSA-vxr8-fq34-vvx9
More information
Details
Impact
A DOMPurify instance that is reused across trust boundaries can stay bound to a previously supplied
TRUSTED_TYPES_POLICYeven afterclearConfig()is called. A later caller that requestsRETURN_TRUSTED_TYPEreceives aTrustedHTMLobject created by the old policy, not by a clean default configuration.If the old policy is unsafe or controlled by a less-trusted integration, this turns a later "default" sanitize call into script execution at a Trusted Types sink.
TRUSTED_TYPES_POLICY: nullon the later call also does not clear the retained policy.dompurify-trusted-types-policy-survives-clearconfig-poc.js
Affected version
Tested against DOMPurify
3.4.8, repository commit825e617753ac1169306a542d3174a77f717a0cf6.Root cause
_parseConfig()overwritestrustedTypesPolicywhencfg.TRUSTED_TYPES_POLICYis truthy, but the default/null path only initializes the internal policy whentrustedTypesPolicy === undefined. Once a custom policy has been set, later default config parsing leaves it in place.Relevant code:
src/purify.ts:786-812accepts and storescfg.TRUSTED_TYPES_POLICY.src/purify.ts:813-832does not reset an existing policy when config has no policy or hasTRUSTED_TYPES_POLICY: null.src/purify.ts:2123-2125signs the final serialized HTML with the retained policy whenRETURN_TRUSTED_TYPEis true.src/purify.ts:2133-2136clearConfig()only clearsCONFIGandSET_CONFIG; it does not resettrustedTypesPolicyoremptyHTML.Local PoC
Run from the DOMPurify checkout, or set
DOMPURIFY_REPO:Observed output:
{ "result": { "baseline": "<b>baseline</b>", "duringPolicy": "<img src=x onerror=alert(\"TT_POLICY_SURVIVED_CLEARCONFIG\")>", "afterClearString": "<img src=\"x\">", "afterClearTrustedType": "[object TrustedHTML]", "afterClearTrusted": "<img src=x onerror=alert(\"TT_POLICY_SURVIVED_CLEARCONFIG\")>", "afterNullTrusted": "<img src=x onerror=alert(\"TT_POLICY_SURVIVED_CLEARCONFIG\")>", "mountedHTML": "<img src=\"x\" onerror=\"alert("TT_POLICY_SURVIVED_CLEARCONFIG")\">" }, "dialogs": [ "TT_POLICY_SURVIVED_CLEARCONFIG" ] }The important part is the split behavior after cleanup:
purify.clearConfig(); purify.sanitize(...);returns a normal sanitized string (<img src="x">), because the later call is not asking for a Trusted Type.purify.clearConfig(); purify.sanitize(..., { RETURN_TRUSTED_TYPE: true });still uses the old policy and returns attacker-controlledTrustedHTML.{ TRUSTED_TYPES_POLICY: null, RETURN_TRUSTED_TYPE: true }also still returns attacker-controlledTrustedHTML.Preconditions
This is a shared-instance state contamination issue. It matters when one DOMPurify instance is reused by multiple integrations, plugins, request handlers, or components with different trust levels, and a cleanup step relies on
clearConfig()to restore safe defaults.This is not a default string-input bypass. An attacker must be able to influence a prior
TRUSTED_TYPES_POLICYon the reused instance, or a less-trusted integration must have installed an unsafe policy.Severity
impact is XSS at a Trusted Types sink in applications that reuse a DOMPurify instance across trust boundaries. Attack complexity is high because exploitation depends on prior policy injection or a less-trusted integration and a later
RETURN_TRUSTED_TYPEsink.Suggested fix
Make
clearConfig()reset Trusted Types state as part of restoring defaults, or have_parseConfig()explicitly cleartrustedTypesPolicyandemptyHTMLwhenTRUSTED_TYPES_POLICY: nullis supplied.Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:A/VC:N/VI:N/VA:N/SC:L/SI:L/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
cure53/DOMPurify (dompurify)
v3.4.9: DOMPurify 3.4.9Compare Source
IN_PLACEsanitization, thanks @mozfreddybIN_PLACEand Trusted Types related usageConfiguration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.