Fix intermittent overlay auto-hide - #280
Open
Perecli wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
runAction()callsshowController()for every tracked media element.showController()stored its timeout in one page-globaltimer, so showing a later controller cleared the pending timeout for an earlier controller. On pages with multiple media elements, the visible overlay could therefore retain thevcs-showclass indefinitely and remain onscreen until the user pressedV.Fix
Store the timeout on the controller element itself (
controller.showTimeOut). Re-showing a controller now resets only its own timeout, while showing another controller cannot cancel it.The existing two-second delay and all shortcut, speed, positioning, and visibility behavior remain unchanged.
Validation
node --check inject.jsgit diff --check