Skip to content

Fix intermittent overlay auto-hide - #280

Open
Perecli wants to merge 1 commit into
codebicycle:firefox-portfrom
Perecli:fix-overlay-autohide-timer
Open

Fix intermittent overlay auto-hide#280
Perecli wants to merge 1 commit into
codebicycle:firefox-portfrom
Perecli:fix-overlay-autohide-timer

Conversation

@Perecli

@Perecli Perecli commented Aug 26, 2026

Copy link
Copy Markdown

Bug

runAction() calls showController() for every tracked media element. showController() stored its timeout in one page-global timer, so showing a later controller cleared the pending timeout for an earlier controller. On pages with multiple media elements, the visible overlay could therefore retain the vcs-show class indefinitely and remain onscreen until the user pressed V.

Fix

Store the timeout on the controller element itself (controller.showTimeOut). Re-showing a controller now resets only its own timeout, while showing another controller cannot cancel it.

The existing two-second delay and all shortcut, speed, positioning, and visibility behavior remain unchanged.

Validation

  • node --check inject.js
  • Local regression harness covering two controllers and same-controller timer refresh
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant