Repository navigation
fix(server): skip endpoint probing when unreachable - #5816
Open
ulischulte wants to merge 2 commits into
Open
ulischulte wants to merge 2 commits into
ulischulte wants to merge 2 commits into
Conversation
A transport error on the actuator index query (connection refused, reset, timeout) made ChainingStrategy fall back to probing, firing one OPTIONS request per configured endpoint that could never succeed. The empty result then overwrote previously detected endpoints. Transport errors now propagate instead of yielding empty, and EndpointDetector keeps existing endpoints when detection fails. Closes #5778
Catching every error in EndpointDetector hid real bugs behind a WARN with no stack trace. The trigger already logs errors with the full stack, and nothing is saved on error, so existing endpoints are kept either way. Treat any IOException in the cause chain as a transport error, so a reset during the body read no longer falls back to probing. Codec errors still fall back because the instance is reachable.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transport error on the actuator index query (connection refused,
reset, timeout) made ChainingStrategy fall back to probing, firing one
OPTIONS request per configured endpoint that could never succeed.
The empty result then overwrote previously detected endpoints.
Transport errors now propagate instead of yielding empty, and
EndpointDetector keeps existing endpoints when detection fails.
Closes #5778