Skip to content

refactor: one rule per file, close detection gaps, generate README - #1

Merged
DavertMik merged 1 commit into
mainfrom
refactor/rules-per-file
Oct 14, 2026
Merged

DavertMik merged 1 commit into
mainfrom
refactor/rules-per-file

Conversation

@DenysKuchma

@DenysKuchma DenysKuchma commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Splits the 12 rules from a single lib/rules.js into lib/rules/<rule-id>.js (plus base.js, utils.js, index.js — same
default-export contract), fixes rule gaps found while dogfooding on a real CodeceptJS + TS project, and adds test coverage (36 tests, up from 24; the 2 previously failing Windows tests are fixed).

Rule fixes: window./globalThis. setTimeout/fetch now caught; this.pause(); computed process.env['X'] credentials; await-grab no longer flags .then() chains, now flags argument/object-property usage.

Linter fixes: parse errors carry file context; finding.source truncated to one line / 120 chars; Windows path normalization; TS
configs importing .js paths of .ts files load when the project has tsx installed.

Docs: README rules table is now generated from rule definitions (npm run docs).

https://github.com/codeceptjs/lint/pull/1
https://github.com/codeceptjs/skills/pull/4

@DenysKuchma
DenysKuchma requested a review from DavertMik October 12, 2026 19:07
@DavertMik
DavertMik merged commit 10db771 into main Oct 14, 2026
1 check passed
@DavertMik
DavertMik deleted the refactor/rules-per-file branch October 14, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants