fix: handle missing slug in create-report command - #785
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the
create-reportcommand would crash with aValueError: The provided slug is invalidif theslugargument wasNone.The root cause was that
encode_slug(called bycreate_report_logic) does not acceptNoneas a valid slug. Theslugcould beNoneif it was not explicitly provided via the--slugCLI option and could not be auto-detected by the CI adapter (e.g., when running in a non-CI local environment).The fix introduces a check at the beginning of
create_report_logicto explicitly verify ifslugisNone. If it is, aclick.ClickExceptionis raised with a user-friendly message, guiding the user to either provide the--slugoption or ensure their CI environment is correctly configured. This prevents the unhandledValueErrorand provides a clearer error experience.Fixes CLI-GZ
This PR was automatically generated by Sentry. You can adjust this setting at any time.