fix: Handle KeyError in CodecovOption fallback lookups - #788
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Author
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an AssertionError in CLI validation tests (e.g.,
validate_empty_upload.py) caused by aKeyErrorwhenCodecovOption.get_defaultattempts to retrieve fallback values from CI adapter mocks.The root cause was that mock CI adapters, which often use direct dictionary access (
[field]), did not always contain allFallbackFieldEnumkeys that the CLI command might query. When a missing key was accessed, it raised aKeyError, which was then captured by the CLI runner, leading to a non-zero exit code and failing assertions.The fix involves wrapping the
ci_adapter.get_fallback_valueandversioning_system.get_fallback_valuecalls withinCodecovOption.get_defaultintry/except KeyErrorblocks. If aKeyErroroccurs,resis set toNone, allowing the fallback mechanism to gracefully continue as if no value was found for that field, rather than crashing.Fixes CLI-H4
This PR was automatically generated by Sentry. You can adjust this setting at any time.