Skip to content

fix: make empty-upload commit creation conditional - #800

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/empty-upload-conditional-commit-bvE0LC
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/empty-upload-conditional-commit-bvE0LC

Conversation

@sentry

@sentry sentry Bot commented Oct 2, 2026

Copy link
Copy Markdown

This PR addresses an AssertionError occurring in a test for the empty-upload command. The root cause was that the create_commit_logic function was unconditionally called within the empty-upload command, even when no explicit commit-related arguments (--parent-sha, --pr, --branch) were provided by the user.

The fix introduces a check to ensure that create_commit_logic is only invoked if the user has explicitly supplied one of these arguments via the command line or environment variables. Values derived from CI/versioning system fallbacks (e.g., automatically detected branch from git) will no longer trigger commit creation. This aligns the command's behavior with the expectations of the verification script and its original intent before commit #654.

Fixes CLI-HJ

@sentry <feedback>: Autofix iterates on these changes
@sentry stop iterating: Autofix stops iterating on this run

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
723 1 722 1
View the full list of 1 ❄️ flaky test(s)
api.temp.calculator.test_calculator::test_divide

Flake rate in main: 100.00% (Passed 0 times, Failed 1726 times)

Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants