Repository navigation
Conversation
Contributor
Author
|
Landed directly on master, reordered to sit before the version commit so the release tag stays on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things, both spotted in review.
9.14 was missing from
gcroots. When I added it toallVersionsI didn't add it to the gc roots list, which names each GHC's build inputs explicitly — so 9.14's dependency closure was eligible for collection and would be rebuilt from scratch after a gc. Now listed alongside the others.9.2 is dropped to save build resources. It was costing two more variants in every release (7 GHCs × 4 platforms) and two more CI jobs, for a compiler nothing selects: codedown-languages' haskell kernel offers
ghc94throughghc912only, so its hnls.nixghc92entries are dead. Removed fromallVersions,gcroots, both CI matrices,test-build,build_all_stack.sh,nix/ghc-libs.nixand the native-bignum overlay, andstack/stack-9.2.8.yamlis deleted.The nix matrix's "test one non-static one" slot moves from
ghc92toghc94, keeping the intent of exercising the older-haskell.nix path, which 9.4 still uses..#ghc914,.#ghc94-static,.#ghc912-staticand.#gcrootsall evaluate;.#ghc92is gone.