Skip to content

Untransform workspace/applyEdit so edits reach the client as notebook edits - #16

Merged
thomasjm merged 2 commits into
masterfrom
applyedit-untransform
Oct 15, 2026
Merged

thomasjm merged 2 commits into
masterfrom
applyedit-untransform

Conversation

@thomasjm

Copy link
Copy Markdown
Contributor

Depends on codedownio/notebook-language-server-core#4.

workspace/applyEdit reached the client naming the shadow document, at the shadow document's coordinates, so the client refused it. Core untransforms it now, which makes transformServerReq monadic — hence the one-line change in app/Main.hs.

This also picks up core#2, which made textDocument/formatting opt-in. HLS's formatters reject the .ipynb extension and none of the seven transformers implement unproject, so notebookConfigHandlesFormatting = False keeps the current behaviour.

Every HLS code lens is typesignature.add and does its work through workspace/applyEdit, so this is what makes Haskell code lenses work at all.

@thomasjm
thomasjm merged commit 22e85cb into master Oct 15, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant